Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable idrac-wsman BIOS interface #162

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

demonCoder95
Copy link
Member

I'm working on BIOS configuration with the idrac-wsman driver. Since this requires enabling the interface, I've edited the ironic.conf to do so.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2020
@demonCoder95
Copy link
Member Author

/assign @hardys @dhellmann @maelk

@jtwill98
Copy link

LGTM, +1

Copy link

@jtwill98 jtwill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@maelk
Copy link
Member

maelk commented Jul 1, 2020

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@demonCoder95
Copy link
Member Author

@maelk can you give this /test-integration so this can merge? It's a tiny patch and has been sitting idle for a few weeks now.

@dhellmann
Copy link
Member

/test-integration

1 similar comment
@maelk
Copy link
Member

maelk commented Jul 28, 2020

/test-integration

@demonCoder95
Copy link
Member Author

I see this error in the CI log, I'm not sure what to make of this. Does the test simply require a rerun?

   - Waiting for task completion (up to 2400 seconds)  - Command: 'check_bm_hosts node-0 ipmi://192.168.111.1:6230 admin password 00:27:5b:70:ee:71'
OK - node-0 Baremetalhost exist
OK - node-0 Baremetalhost address correct
OK - node-0 Baremetalhost mac address correct
FAIL - node-0 Baremetalhost status OK
       expected OK, got 
OK - node-0 Baremetalhost credentials secret exist
OK - node-0 Baremetalhost password correct
OK - node-0 Baremetalhost user correct
OK - node-0 Baremetalhost VM exist
OK - node-0 Baremetalhost VM interface provisioning exist
OK - node-0 Baremetalhost VM interface baremetal exist
FAIL - node-0 Baremetalhost introspecting completed
       expected registering to be in ready available

   - Waiting for task completion (up to 2400 seconds)  - Command: 'check_bm_hosts node-1 redfish+http://192.168.111.1:8000/redfish/v1/Systems/890a9af5-f4ae-4b65-bddf-8c42d638d946 admin password 00:27:5b:70:ee:75'
Cancelling nested steps due to timeout

@demonCoder95
Copy link
Member Author

@maelk @dhellmann

@dhellmann
Copy link
Member

I see this error in the CI log, I'm not sure what to make of this. Does the test simply require a rerun?

   - Waiting for task completion (up to 2400 seconds)  - Command: 'check_bm_hosts node-0 ipmi://192.168.111.1:6230 admin password 00:27:5b:70:ee:71'
OK - node-0 Baremetalhost exist
OK - node-0 Baremetalhost address correct
OK - node-0 Baremetalhost mac address correct
FAIL - node-0 Baremetalhost status OK
       expected OK, got 
OK - node-0 Baremetalhost credentials secret exist
OK - node-0 Baremetalhost password correct
OK - node-0 Baremetalhost user correct
OK - node-0 Baremetalhost VM exist
OK - node-0 Baremetalhost VM interface provisioning exist
OK - node-0 Baremetalhost VM interface baremetal exist
FAIL - node-0 Baremetalhost introspecting completed
       expected registering to be in ready available

   - Waiting for task completion (up to 2400 seconds)  - Command: 'check_bm_hosts node-1 redfish+http://192.168.111.1:8000/redfish/v1/Systems/890a9af5-f4ae-4b65-bddf-8c42d638d946 admin password 00:27:5b:70:ee:75'
Cancelling nested steps due to timeout

It sounds like something is failing. Does the test job collect any logs from Ironic?

@demonCoder95
Copy link
Member Author

Yes, the job has a tarball artifact that contains all the logs, including ironic logs.

@demonCoder95
Copy link
Member Author

A quick look shows me the following, which basically means the ironic-api server is misbehaving

[00m
2020-07-28 16:47:53.030 136 ERROR ironic.api.expose [req-0b3f3e1f-cbcb-4ae2-9282-0d422eea2ef9 - - - - -] Server-side error: "Resource temporarily unavailable, please retry.". Detail: 
Traceback (most recent call last):

  File "/usr/lib/python3.6/site-packages/ironic/api/expose.py", line 77, in callfunction

Also there's this

DEBUG ironic.api.expose [req-db93cb4b-6e63-44ac-b3d5-5ad1c5665389 - - - - -] Client-side error: Node node-1 could not be found. format_exception /usr/lib/python3.6/site-packages/ironic/api/expose.py:180�[00m
2020-07-28 16:47:53.097 136 INFO eventlet.wsgi.server [req-db93cb4b-6e63-44ac-b3d5-5ad1c5665389 - - - - -] ::ffff:172.18.0.2 "GET /v1/nodes/node-1 HTTP/1.1" status: 404  len: 451 time: 0.0307040

@demonCoder95
Copy link
Member Author

Looks like the job might simply need another rerun? Or does the CI have issues?

@demonCoder95
Copy link
Member Author

Can we rerun the test on this PR? @dhellmann @maelk

@dhellmann
Copy link
Member

@demonCoder95 since you're a member of the org, I think you can trigger the tests. Try it and let's see. If it doesn't work, I'll run the tests and then we can figure out what other permissions you need.

@demonCoder95
Copy link
Member Author

/test-integration

@demonCoder95
Copy link
Member Author

Doesn't seem to work.

@dhellmann
Copy link
Member

Doesn't seem to work.

Ah, you're not a member of the org. I've sent you an invitation. After you accept it, make sure your membership is public so the bot can see it.

@demonCoder95
Copy link
Member Author

Just accepted it. Let's try again..
/test-integration

@demonCoder95
Copy link
Member Author

/test-integration

@demonCoder95
Copy link
Member Author

/retest

@metal3-io-bot
Copy link
Contributor

@demonCoder95: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@demonCoder95
Copy link
Member Author

/ok-to-test

@metal3-io-bot
Copy link
Contributor

@demonCoder95: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@demonCoder95
Copy link
Member Author

Well, now there's that shrug @dhellmann

@demonCoder95
Copy link
Member Author

/shrug

@metal3-io-bot metal3-io-bot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Aug 6, 2020
@dhellmann
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 6, 2020
@dhellmann
Copy link
Member

/retest

@dhellmann
Copy link
Member

I'm not sure exactly what's missing. Maybe we can talk about this on slack where some of the folks who administer the CI stuff can answer.

@demonCoder95
Copy link
Member Author

Sounds good!

@demonCoder95
Copy link
Member Author

/retest

@russellb
Copy link
Member

russellb commented Aug 6, 2020

/honk

@demonCoder95
Copy link
Member Author

Solving this issues looks like a wild goose chase. What a fitting label to have! honk honk xD

@russellb
Copy link
Member

russellb commented Aug 6, 2020

/woof

@metal3-io-bot
Copy link
Contributor

@russellb: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@demonCoder95
Copy link
Member Author

/test-integration

@demonCoder95
Copy link
Member Author

@russellb @dhellmann @maelk I think this is good to go now!

@dhellmann
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: demonCoder95, dhellmann, jtwill98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@metal3-io-bot metal3-io-bot merged commit ef65ecd into metal3-io:master Aug 7, 2020
@maelk
Copy link
Member

maelk commented Aug 10, 2020

This broke the metal3-dev-env deployments. We would propose to revert it in #189 and give it a new try afterwards. This passed the CI because there was a bug in metal3-dev-env and the image was actually not tested. This should be fixed now.

bfournie pushed a commit to bfournie/ironic-image that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants