Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 'idrac-wsman' interface for RAID Configuration #181

Closed
wants to merge 0 commits into from
Closed

Enable 'idrac-wsman' interface for RAID Configuration #181

wants to merge 0 commits into from

Conversation

nasirkamal
Copy link

@nasirkamal nasirkamal commented Jul 28, 2020 •
edited

Enable 'idrac-wsman' interface in ironic.conf for inspect, management, power and raid. This is important to configure and manage Dell Power Edge servers.

This is related to PR #146, where I accidentally deleted the parent repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2020
dtantsur
dtantsur requested changes Jul 28, 2020
View reviewed changes
ironic.conf Outdated Show resolved Hide resolved
ironic.conf Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2020
@nasirkamal nasirkamal mentioned this pull request Jul 28, 2020
Closed
@nasirkamal nasirkamal changed the title Enable 'idrac-wsman' interface for inspect, management, power, raid and vendor Enable 'idrac-wsman' interface for inspect, management, power and raid Jul 28, 2020
@nasirkamal nasirkamal changed the title Enable 'idrac-wsman' interface for inspect, management, power and raid Enable 'idrac-wsman' interface for RAID Configuration Jul 30, 2020
@nasirkamal nasirkamal requested a review from dtantsur July 30, 2020 07:55
@nasirkamal
Copy link
Author

/assign @hardys

@demonCoder95
Copy link
Member

@maelk I think this is good to go now!

@demonCoder95
Copy link
Member

Can we rerun the test on this? @maelk @dhellmann

@demonCoder95
Copy link
Member

/test-integration

@demonCoder95
Copy link
Member

@russellb @dhellmann @maelk This is a patch similar to mine. all testing done, it's good to go as well!

@dhellmann
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@demonCoder95
Copy link
Member

@dhellmann why hasn't this merged yet? Does it require an LGTM label in addition to the approve label?

@furkatgofurov7 furkatgofurov7 mentioned this pull request Aug 10, 2020
Merged
@maelk
Copy link
Member

maelk commented Aug 10, 2020

The CI is currently broken after #162 went in. However, reverting it might break this PR ? Maybe the rework of enabling the bios interface could be done here too ?

@nasirkamal nasirkamal closed this Oct 15, 2020
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, nasirkamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Jun 17, 2021
@openshift-merge-robot
Merge pull request metal3-io#181 from openshift-ci-robot/updating-.ci…
40f642e 
…-operator.yaml-`build_root_image`-from-openshift/release

Updating .ci-operator.yaml `build_root_image` from openshift/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demonCoder95 demonCoder95 demonCoder95 left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nasirkamal @demonCoder95 @dhellmann @maelk @metal3-io-bot @dtantsur @hardys