Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Provide scripts to be used as liveness/readiness probes #492

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Apr 4, 2024

This change is the first step towards metal3-io/baremetal-operator#1528.
Through these scripts, we can decouple the validation logic from
the pod definition and provide more sophisticated tests in the future.

Right now, the same curl command is used (modulo supporting all variants
of deploying Ironic).

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Apr 4, 2024

/cc @tuminoid
/hold

I need to find a way to test these, they're not currently wired in.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight typo.

This can be tested with dev-env PR and configuring BMO and ironic-image to point to your forks with needed changes with BMOREPO, BMOBRANCH and IRONIC_IMAGE_REPO , IRONIC_IMAGE_BRANCH (see vars.sh).

Or locally, by pointing dev-env to local repos via BMOPATH and IRONIC_IMAGE_PATH and setting BUILD_BMO_LOCALLY=true and BUILD_IRONIC_IMAGE_LOCALLY=true. Also set FORCE_REPO_UPDATE=false.

scripts/configure-ironic.sh Outdated Show resolved Hide resolved
@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

Or locally, by pointing dev-env to local repos via BMOPATH and IRONIC_IMAGE_PATH and setting BUILD_BMO_LOCALLY=true and BUILD_IRONIC_IMAGE_LOCALLY=true. Also set FORCE_REPO_UPDATE=false.

I'm running this test now locally.

This change is the first step towards
metal3-io/baremetal-operator#1528.
Through these scripts, we can decouple the validation logic from
the pod definition and provide more sophisticated tests in the future.

Right now, the same curl command is used (modulo supporting all variants
of deploying Ironic).

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Apr 5, 2024

/test-centos-integration-main

@dtantsur
Copy link
Member Author

dtantsur commented Apr 5, 2024

/test-ubuntu-integration-main

1 similar comment
@tuminoid
Copy link
Member

tuminoid commented Apr 5, 2024

/test-ubuntu-integration-main

@dtantsur
Copy link
Member Author

dtantsur commented Apr 5, 2024

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@derekhiggins
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@iurygregory
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@metal3-io-bot metal3-io-bot merged commit bf3fa39 into metal3-io:main Apr 5, 2024
7 of 8 checks passed
@dtantsur dtantsur deleted the probes branch April 8, 2024 11:23
@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/cherry-pick release-24.1

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #493

In response to this:

/cherry-pick release-24.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants