Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Provide scripts to be used as liveness/readiness probes #493

Merged
merged 1 commit into from
Apr 12, 2024
Merged

✨ Provide scripts to be used as liveness/readiness probes #493

merged 1 commit into from
Apr 12, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #492

/assign tuminoid

@dtantsur
Provide scripts to be used as liveness/readiness probes
e44c4f7 
This change is the first step towards
metal3-io/baremetal-operator#1528.
Through these scripts, we can decouple the validation logic from
the pod definition and provide more sophisticated tests in the future.

Right now, the same curl command is used (modulo supporting all variants
of deploying Ironic).

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot mentioned this pull request Apr 9, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/retitle ✨ Provide scripts to be used as liveness/readiness probes

@metal3-io-bot metal3-io-bot changed the title [release-24.1] ✨ Provide scripts to be used as liveness/readiness probes ✨ Provide scripts to be used as liveness/readiness probes Apr 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

1 similar comment
@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/cc @dtantsur

@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main
Cmoon jenkins...

@tuminoid
Copy link
Member

tuminoid commented Apr 9, 2024

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@tuminoid
Copy link
Member

/hold
We are missing triggers in Jenkins for the release branches, need to fix those to run tests.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@tuminoid tuminoid mentioned this pull request Apr 10, 2024
Merged
tuminoid
tuminoid reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Prow triggers being added here: metal3-io/project-infra#693

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor Author

@mboukhalfa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test markdownlint
  • /test shellcheck

Use /test all to run the following jobs that were automatically triggered:

  • shellcheck

In response to this:

/test metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member

/test ?

@metal3-io-bot
Copy link
Contributor Author

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test markdownlint
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-centos-e2e-integration-test-release-1-4
  • /test metal3-centos-e2e-integration-test-release-1-5
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-release-1-4
  • /test metal3-ubuntu-e2e-integration-test-release-1-5
  • /test metal3-ubuntu-e2e-integration-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • shellcheck

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-integration-test-main

@tuminoid
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

Running with the new keywords, and checking if they actually run the right tests. After that, will change the required tests configs.

@tuminoid tuminoid mentioned this pull request Apr 11, 2024
Closed
@kashifest
Copy link
Member

/test-ubuntu-integration-main

@kashifest
Copy link
Member

/test-ubuntu-integration-main

@kashifest
Copy link
Member

/test-centos-integration-main

2 similar comments
@kashifest
Copy link
Member

/test-centos-integration-main

@kashifest
Copy link
Member

/test-centos-integration-main

@kashifest
Copy link
Member

/test-ironic-image-build

@kashifest
Copy link
Member

/test-ubuntu-integration-main

@kashifest
Copy link
Member

/test-ironic-image-build

@kashifest
Copy link
Member

/test-centos-integration-main

@tuminoid
Copy link
Member

OK, CI should be now Prow only, removed required Jenkins contexts.
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@metal3-io-bot metal3-io-bot merged commit 5fade07 into metal3-io:release-24.1 Apr 12, 2024
9 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request May 20, 2024
@openshift-merge-bot
Merge pull request metal3-io#493 from elfosardo/remove-cinder-glance-…
0a0cd71 
…clients

METAL-1005: [4.16] Update ironic projects and remove cinder and glance clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@metal3-io-bot @tuminoid @elfosardo @mboukhalfa @kashifest @dtantsur