⚠️ Use unix sockets by default for reverse proxy communication #495
Conversation
Using additional ports increase the chance of conflicting with something else on the node and is also potentially less efficient. We have used Unix sockets via a shared directory in OpenShift for a while without any complaints. I think upstream should do the same. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
metal3-io-bot
added
the
size/XS
|
/rettile |
|
/hold Also needs #493 to merge first. |
metal3-io-bot
added
the
do-not-merge/hold
|
/retitle |
metal3-io-bot
changed the title
There was a problem hiding this comment.
/lgtm
Prow triggers being added here: metal3-io/project-infra#693
|
/test metal3-centos-e2e-integration-test-main Running with the new keywords, and checking if they actually run the right tests. After that, will change the required tests configs. |
|
/test-centos-integration-main |
1 similar comment
|
/test-centos-integration-main |
|
/retest |
|
Just checking what Prow now shows for this branch: /test ? |
|
@tuminoid: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
Yes, I was just waiting if I need to rebase this on top of the other or if the CI handles testing that properly. |
metal3-io-bot
removed
the
do-not-merge/hold
This is an automated cherry-pick of #494
/assign tuminoid