Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 🌱 remove world-writable socket #501

Closed
wants to merge 1 commit into from
Closed

WIP: 🌱 remove world-writable socket #501

wants to merge 1 commit into from

Conversation

tuminoid
Copy link
Member

We don't need a world-writable socket anymore. Group write is enough as we have users created in configure-nonroot.sh to share GIDs, and on top, Inspector is now removed.

@tuminoid
remove world-writable socket
cd3d744 
We don't need a world-writable socket anymore. Group write is enough
as we have users created in configure-nonroot.sh to share GIDs, and on
top, Inspector is now removed.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elfosardo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@tuminoid
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main cd3d744 link true /test metal3-ubuntu-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Contributor

@tuminoid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main cd3d744 link true /test metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tuminoid
Copy link
Member Author

Since Centos passed and Ubuntu didn't, I guess we have issues still with the Ironic sockets in local Ironic installation, as mounts are different than in Centos/K8s installation.

/close

@metal3-io-bot
Copy link
Contributor

@tuminoid: Closed this PR.

In response to this:

Since Centos passed and Ubuntu didn't, I guess we have issues still with the Ironic sockets in local Ironic installation, as mounts are different than in Centos/K8s installation.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/change-socket-bits branch May 24, 2024 07:26
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Jun 10, 2024
@openshift-merge-bot
Merge pull request metal3-io#501 from openshift-bot/art-consistency-o…
ade65b6 
…penshift-4.17-ironic

OCPBUGS-33902: Updating ironic-container image to be consistent with ART for 4.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuminoid @metal3-io-bot