Wait for PROVISIONING_INTERFACE to be up #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
russellb
reviewed
Aug 16, 2019
rundnsmasq.sh
Outdated
| @@ -17,7 +22,7 @@ mkdir -p /shared/log/dnsmasq | |||
| cp /usr/share/ipxe/undionly.kpxe /usr/share/ipxe/ipxe.efi /shared/tftpboot | |||
|
|
|||
| # Use configured values | |||
| sed -i -e s/IRONIC_IP/${PROVISIONING_IP}/g -e s/HTTP_PORT/${HTTP_PORT}/g \ | |||
| sed -i -e s/PROVISIONING_IP/${PROVISIONING_IP}/g -e s/HTTP_PORT/${HTTP_PORT}/g \ | |||
There was a problem hiding this comment.
This change doesn't look right
There was a problem hiding this comment.
I checked /etc/dnsmasq.conf and it looks like it still expects IRONIC_IP to be substituted
There was a problem hiding this comment.
Thanks, that's a sed mistake, now fixed!
We've seen some issues where the static-ip-refresh doesn't happen quickly enough, and/or static-ip-set from initContainers expires before we start the ironic containers. To ensure we don't fail in that case, wait for the provisioning IP to be assigned, then the exact order of container start is not important, and we'll wait until static-ip-refresh has configured the nic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some issues where the static-ip-refresh doesn't happen quickly
enough, and/or static-ip-set from initContainers expires before we start
the ironic containers.
To ensure we don't fail in that case, wait for the provisioning IP to be
assigned, then the exact order of container start is not important, and
we'll wait until static-ip-refresh has configured the nic.