Wait for provisioning interface and db sync #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2019 16:01
We've seen some issues where the static-ip-refresh doesn't happen quickly enough, and/or static-ip-set from initContainers expires before we start the ironic containers. To ensure we don't fail in that case, wait for the provisioning IP to be assigned, then the exact order of container start is not important, and we'll wait until static-ip-refresh has configured the nic.
I've seen some situations where mariadb is not up soon enough for the dbsync, despite the 10 retries done inside ironic-dbsync. In this situation we start the ironic services anyway and since metal3-io#80 got reverted, we can't rely on pod/container restart to handle this, so lets retry inside the script logging a warning instead.
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
21 tasks
|
Image build in CI failed on:
|
|
/retest |
|
Based on the build log, it looks like it's building with el7 rpms, but Dockerfile.ocp has python3-PyMySQL assuming el8. |
|
/retest |
hardys
pushed a commit
to hardys/ironic-image
that referenced
this pull request
Aug 20, 2019
This is a dependency of the ironic packages (via the python2-oslo-db package) already, and copying this dependency to the downstream el8 based dockerfile has caused issues since[1] made some of the image building checks stricter, I assume this is because the package name is different but I don't have a specfile reference atm. This has led to [2] failing CI, and rather than just fix that downstream we should probably make things consistent and remove this spuruious install, then let RPM dependencies defined by the package maintainers do the right thing on each platform? [1] openshift/images#11 [2] openshift#15
This is a dependency of the ironic packages (via the python2-oslo-db package) already, and copying this dependency to the downstream el8 based dockerfile has caused issues since[1] made some of the image building checks stricter, I assume this is because the package name is different but I don't have a specfile reference atm. This has led to [2] failing CI, and rather than just fix that downstream we should probably make things consistent and remove this spuruious install, then let RPM dependencies defined by the package maintainers do the right thing on each platform? [1] openshift/images#11 [2] openshift#15
hardys
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Thanks to @stbenjam for pointing out openshift/images#11 which may be the root cause of the CI failure, e.g some errors from yum have been ignored but now cause failure. I pushed metal3-io#90 and added the same commit here to see if that is sufficient to resolve the build issue, marked this WIP until that is confirmed |
hardys
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
we can remove the WIP, verified the correct package is installed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, hardys, juliakreger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks of the following upstream PRs
metal3-io#88
metal3-io#89