Install tripleo current repos for Centos 8 #187
Conversation
The correct path for Centos 8 TripleO repos is current and not current-tripleo.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
size/XS
|
Hi @elfosardo. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
|
Thanks @elfosardo this looks OK but I took a different approach in #157 Since we now have the vbmc running in a container, the only thing we actually install from RDO AFAICS is ironicclient/openstackclient, so I'm wondering if we should just stop enabling the RDO repos (which is what I did in my PR, instead pip installing the client). Another approach could be to have an ironic-client container which just contains the client, and this would also be useful for debugging on a cluster where the client may not be installed anywhere? I actually proposed openshift/ironic-image#17 a while back to add the client to ironic-image, so one option would be to do that in the metal3 image, but perhaps a new smaller image would be preferable? @maelk any thoughts on the preferred option here, and what would work best for other platforms? |
|
@hardys When it comes to the client, I think the easiest would be to install it with pip in metal3-dev-env. It's the most straightforward from a user perspective. That being said, I really like the idea of having a container image that we could use to debug in certain situations (like on a management cluster that is not in metal3-dev-env) |
|
@maelk yes agree pip is the easiest, and that's what I did in #157 - some folks have objected to using pip system-wide in the past, but it seems reasonable in this case (we could look at using pip --user in future). If we're OK with that approach I'll rebase/re-test #157 and we then potentially won't need the RDO repos anymore. If this PR is needed as an immediate fix I'm fine with it though. |
In metal3-io/metal3-dev-env#187 we discuss the current usage of the RDO repos, and since virtualbmc is now containerized, the only things we install from the RDO repos are the python ironic clients. For development and debugging, it's helpful to have these available, and also in real production environments for collecting debug information (and in this latter case it's often not possible to e.g pip install some clients, so having them available in an image already accessible to the cluster is useful).
In metal3-io/metal3-dev-env#187 we discuss the current usage of the RDO repos, and since virtualbmc is now containerized, the only things we install from the RDO repos are the python ironic clients. For development and debugging, it's helpful to have these available, and also in real production environments for collecting debug information (and in this latter case it's often not possible to e.g pip install some clients, so having them available in an image already accessible to the cluster is useful). This can be used interactively e.g: podman run -ti --entrypoint='["/usr/bin/openstack", "baremetal", "node", "list"]' \ -v /home/shardy/dev-scripts/etc_openstack:/etc/openstack \ -e OS_CLOUD=$OS_CLOUD localhost/ironic_client Clearly we could add a shell alias or wrapper function to make this transparent and act like the current installed client.
|
@elfosardo when you get time please see #223 and #215 which I'm proposing as an alternative - with that approach we remove the RDO repo requirement completely for CentOS8 |
|
@elfosardo should we close this one and go with #223 ? |
|
obsoleted by #223 |
The correct path for Centos 8 TripleO repos is current and not
current-tripleo.