Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge offensive language from Metal3-io repositories #117

Closed
maelk opened this issue Jul 1, 2020 · 22 comments
Closed

Purge offensive language from Metal3-io repositories #117

maelk opened this issue Jul 1, 2020 · 22 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue is ready to be actively worked on.
Projects

Comments

@maelk
Copy link
Member

maelk commented Jul 1, 2020

Following a K8s-wide effort to remove terms such as "master", "slave", "whitelist" and "blacklist", we should take steps to remove this type of words from our repos. In K8S repos, the Github "master" branches will be renamed to "main".

We should follow the movement and remove at least those four words with the following proposed replacements:

  • master -> controlplane
  • slave -> worker
  • whitelist -> allowlist
  • blacklist -> denylist

we should also rename all our master branches to main.

@maelk maelk added this to Selected for development in Roadmap Jul 1, 2020
@dhellmann
Copy link
Member

It would be good to handle the branch renaming in all of our repos quickly to minimize disruption. I imagine a couple of us with admin privileges could go through and do that. Does the k8s community have a set of instructions worked out?

What other changes would we need to make? Does CI need to be reconfigured at the same time?

@maelk maelk moved this from BMO v1alpha1 to Feature request in Roadmap Jul 1, 2020
@maelk maelk moved this from Feature request to Backlog in Roadmap Jul 1, 2020
@demonCoder95
Copy link
Member

It's a questionable move by Github and others in my opinion, changing terminology will not have the desired affect, at all. These are problems of perception and human behaviors, not words. It will only cause software breakage all over the place, adding to the already humongous mess of terminology that has already been in place since forever.

However, the proposed changes look reasonable. So, LGTM. +1

@maelk
Copy link
Member Author

maelk commented Jul 2, 2020

This is also a work in progress on the K8S side. They are starting a work group on this AFAIK. so no instructions yet. The prow config has quite some references to master, especially for container images. They'll need to be changed once all the new images are created. We will also need to change all container images references in all repos (in hack and deploy/config folders).
Jenkins will also need to be reconfigured, that's something that we will take care of when the branch change is done.

I would propose to proceed the following way for the branch renaming :

  • create the main branch in all repositories
  • modify all references to master, in CI and in all repos, specifically for container images
  • modify the default branch
  • Fix CI and Jenkins
  • remove master branch

@dhellmann
Copy link
Member

We may also need to follow the instructions for setting the new default branch. https://docs.github.com/en/github/administering-a-repository/setting-the-default-branch

@stbenjam stbenjam added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 8, 2020
@dhellmann
Copy link
Member

There is some additional guidance on https://github.com/github/renaming suggesting that if we wait a little bit, GitHub will provide better tools to make the transition go more smoothly.

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2020
@maelk
Copy link
Member Author

maelk commented Oct 27, 2020

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2021
@maelk
Copy link
Member Author

maelk commented Jan 26, 2021

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2021
@fmuyassarov
Copy link
Member

It seems that Github has made it easy now to rename the existing branch: https://github.com/github/renaming. Based on that document, the list of the things that will be taken care by Github while renaming is:

  1. Re-target any open pull requests
  2. Update any draft releases based on the branch
  3. Move any branch protection rules that explicitly reference the old name
  4. Update the branch used to build GitHub Pages, if applicable
  5. Show a notice to repository contributors, maintainers, and admins on the repository homepage with instructions to update local copies of the repository
  6. Show a notice to contributors who git push to the old branch
  7. Redirect web requests for the old branch name to the new branch name
  8. Return a "Moved Permanently" response in API requests for the old branch name

@furkatgofurov7
Copy link
Member

@maelk
Copy link
Member Author

maelk commented Mar 30, 2021

This could be tried on a repo that is not much used, such as IPAM ?

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2021
@furkatgofurov7
Copy link
Member

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2021
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2021
@fmuyassarov
Copy link
Member

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2021
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2021
@fmuyassarov
Copy link
Member

/lifecycle active

@metal3-io-bot metal3-io-bot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 26, 2021
@Rozzii
Copy link
Member

Rozzii commented Feb 16, 2022

/triage accepted

@metal3-io-bot metal3-io-bot added the triage/accepted Indicates an issue is ready to be actively worked on. label Feb 16, 2022
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels May 17, 2022
@metal3-io-bot
Copy link
Contributor

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

@metal3-io-bot
Copy link
Contributor

@metal3-io-bot: Closing this issue.

In response to this:

Stale issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle stale.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Roadmap
Backlog
Development

No branches or pull requests

8 participants