Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI Test Matrix #320

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Add CI Test Matrix #320

merged 1 commit into from
Apr 28, 2023

Conversation

Sunnatillo
Copy link
Member

This PR adds CI Test Matrix, describing which branches and image tags are used in CI tests

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 17, 2023
@Sunnatillo Sunnatillo force-pushed the add-ci-test-matrix/sunnat branch 7 times, most recently from 45cd748 to 6377b66 Compare April 17, 2023 09:29
smoshiur1237
smoshiur1237 reviewed Apr 17, 2023
View reviewed changes
docs/user-guide/src/version_support.md Outdated

<!-- markdownlint-disable -->
| Test | CAPM3 branch | IPAM branch | BMO branch/tag | Keepalived tag | MariaDB | VBMC | Sushi-tools | Ironic |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the Test column little bit bigger? some of the test names goes to second line because of less space

Copy link
Member Author

@Sunnatillo Sunnatillo Apr 20, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried several ways, as you can check on different commits. Solution works for vscode preview, but changes did not work on github. I am out of ideas.

@tuminoid tuminoid self-requested a review April 19, 2023 07:22
furkatgofurov7
furkatgofurov7 previously requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc itself is pretty outdated as well, but maybe that is out of the scope for this change

docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
docs/user-guide/src/version_support.md Outdated Show resolved Hide resolved
@Sunnatillo Sunnatillo force-pushed the add-ci-test-matrix/sunnat branch 6 times, most recently from 5b42a76 to aa5d68f Compare April 20, 2023 09:34
tuminoid
tuminoid reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The doc in general needs an update in another PR, but the testing matrix seems fine. It doesn't render well in Github docs, but given the width and amount of information, I don't think that can be helped.

@tuminoid
Copy link
Member

/assign @furkatgofurov7 @kashifest

Let's get this merged.

dtantsur
dtantsur reviewed Apr 26, 2023
View reviewed changes
docs/user-guide/src/version_support.md Outdated

| TESTS | CAPM3 branch | IPAM branch | BMO branch/tag | Keepalived tag | MariaDB | VBMC | sushi-tools | Ironic |
| ------------------------------------ | ------------ | ----------- | --------------- | -------------- | ------- | ------ | ----------- | ------ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we may want to eventually version Ironic and MariaDB, I'd not envision versioning vbmc and sushy-tools (you have a typo in the name btw).

Copy link
Member Author

@Sunnatillo Sunnatillo Apr 27, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. I addressed your comments, Removed sushy-tools and VBMC from the table, added line mentioning we use latest versions of them.

tuminoid
tuminoid reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders bit better now. I think all comments are addressed.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@kashifest
Copy link
Member

Lets update the matrix once more with new release branch and tags ?

@tuminoid
Copy link
Member

Lets update the matrix once more with new release branch and tags ?

Can we do it in another PR, so I can use that PR as an example PR in release documentation?

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@tuminoid tuminoid dismissed furkatgofurov7’s stale review April 28, 2023 09:10

all mentioned issues addressed

@metal3-io-bot metal3-io-bot merged commit a004701 into metal3-io:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@furkatgofurov7 furkatgofurov7 Awaiting requested review from furkatgofurov7

Assignees

@furkatgofurov7 furkatgofurov7

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Sunnatillo @tuminoid @kashifest @metal3-io-bot @dtantsur @furkatgofurov7 @smoshiur1237