-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI Test Matrix #320
Add CI Test Matrix #320
Conversation
45cd748
to
6377b66
Compare
|
||
<!-- markdownlint-disable --> | ||
| Test | CAPM3 branch | IPAM branch | BMO branch/tag | Keepalived tag | MariaDB | VBMC | Sushi-tools | Ironic | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make the Test column little bit bigger? some of the test names goes to second line because of less space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried several ways, as you can check on different commits. Solution works for vscode preview, but changes did not work on github. I am out of ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc itself is pretty outdated as well, but maybe that is out of the scope for this change
5b42a76
to
aa5d68f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The doc in general needs an update in another PR, but the testing matrix seems fine. It doesn't render well in Github docs, but given the width and amount of information, I don't think that can be helped.
/assign @furkatgofurov7 @kashifest Let's get this merged. |
|
||
| TESTS | CAPM3 branch | IPAM branch | BMO branch/tag | Keepalived tag | MariaDB | VBMC | sushi-tools | Ironic | | ||
| ------------------------------------ | ------------ | ----------- | --------------- | -------------- | ------- | ------ | ----------- | ------ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we may want to eventually version Ironic and MariaDB, I'd not envision versioning vbmc and sushy-tools (you have a typo in the name btw).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing. I addressed your comments, Removed sushy-tools and VBMC from the table, added line mentioning we use latest versions of them.
used in periodic CI tests
aa5d68f
to
55c7fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renders bit better now. I think all comments are addressed.
/lgtm
Lets update the matrix once more with new release branch and tags ? |
Can we do it in another PR, so I can use that PR as an example PR in release documentation? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
all mentioned issues addressed
This PR adds CI Test Matrix, describing which branches and image tags are used in CI tests