The fix for "append_tabbed()" (it does not coloring text and bg). #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current append_tabbed() (in main branch) does not coloring text and background (because "tput sc" and "tput rc" save and restore not only cursor position, but color setting too). Solution: move "tput sc" after setcolor/setbgcolor call.
|
Can you please remove the stackdump file ? and don't forget to rebase to master before to push. I will merge that as soon as possible. Thanks a lot ! |
|
rebase - done.
delete stackdump - done.
11 липня 2018, 18:09:37, від "Patrice Ferlet" <notifications@github.com>:
… Can you please remove the stackdump file ? and don't forget to rebase to master before to push. I will merge that as soon as possible. Thanks a lot !
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub|#27 (comment)], or [mute the thread|https://github.com/notifications/unsubscribe-auth/ABT7q5ptxDmVXoON5TOtUYVgaPeJtAb0ks5uFhUwgaJpZM4SBcwj].
---
Regards,
Sergii
+380(67) 236 00 20
|
|
Sorry for the latency - merged ! thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current append_tabbed() (in main branch) does not coloring text and background (because "tput sc" and "tput rc" save and restore not only cursor position, but color setting too).
Solution: move "tput sc" after setcolor/setbgcolor call.