Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment variables to mirrord invocations #70

Closed
aviramha opened this issue Sep 29, 2023 · 4 comments · Fixed by #74
Closed

Pass environment variables to mirrord invocations #70

aviramha opened this issue Sep 29, 2023 · 4 comments · Fixed by #74
Assignees

Comments

@aviramha
Copy link
Member

When setting configuration via env, when it verifies the IDE doesn't pass the env that would be passed to the process so it creates difference between rendering on verification and execution.

@aviramha aviramha changed the title Pass environment variables to verify config execution Pass environment variables to mirrord invocations Oct 3, 2023
@meowjesty
Copy link
Member

Why do we clear the env vars we get from vscode (extension entry-point)?

let mirrordApi = new MirrordAPI(cliPath);
config.env ||= {};
let target = null;

From what I'm getting, you can't set mirrord with env vars in the extension, it has to be set up with a config file.

So the goal here is to make this possible? Set up mirrord completely from env vars in launch.json, and pass this env var config through the usual flow? First checking if it's valid (verify-config), then allowing user to select target, and so on?

@aviramha
Copy link
Member Author

aviramha commented Oct 5, 2023

It's not clearing, it's initializing if it's not initialized
if config.env is null -> config.env = {} else do nothing

@aviramha
Copy link
Member Author

aviramha commented Oct 5, 2023

The goal is to pass "config.env" in the verify-config exec and in the mirrord ext exec to the configuration won't drift between executions.

@meowjesty
Copy link
Member

The env vars from launch.json are now being passed down to mirrord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants