Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env = false in configuration doesn't disable env #1015

Closed
aviramha opened this issue Feb 6, 2023 · 0 comments
Closed

env = false in configuration doesn't disable env #1015

aviramha opened this issue Feb 6, 2023 · 0 comments
Assignees
@DmitryDodzin
Labels
bug Something isn't working

Comments

@aviramha
Copy link
Member

aviramha commented Feb 6, 2023

Bug Description

having mirrord.json file with the following

"feature": {"env": false}

has no effect.

Steps to Reproduce

.

Backtrace

No response

Relevant Logs

No response

Your operating system and version

any

Local process

any

Local process version

No response

Additional Info

No response
@aviramha aviramha added the bug Something isn't working label Feb 6, 2023
@DmitryDodzin DmitryDodzin self-assigned this Feb 6, 2023
@DmitryDodzin DmitryDodzin mentioned this issue Feb 6, 2023
Closed
bors bot pushed a commit that referenced this issue Feb 6, 2023
@DmitryDodzin
Fix config file disabled env (#1018)
7e6d110 
Fix incorrect behavior with env is disabled
```toml
[feature]
env = false
```
now should pass "*" to exclude

closes #1015
bors bot pushed a commit that referenced this issue Feb 6, 2023
@DmitryDodzin
Fix config file disabled env (#1018)
46bace6 
Fix incorrect behavior with env is disabled
```toml
[feature]
env = false
```
now should pass "*" to exclude

closes #1015
@bors bors bot closed this as completed in c8f4416 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryDodzin DmitryDodzin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix config file disabled env DmitryDodzin/mirrord
2 participants
@DmitryDodzin @aviramha