[Merged by Bors] - Fix rare file close deadlock. #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
commented
Feb 3, 2023
aviramha
approved these changes
Feb 5, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
The deadlock has only been observed in the E2E fileops test with Go-1.20 on GitHub Actions. This PR hopefully eliminate this deadlock, but also contains some fixes of problematic lockings that did not cause this deadlock. Part of #994.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deadlock has only been observed in the E2E fileops test with Go-1.20 on GitHub Actions.
This PR hopefully eliminate this deadlock, but also contains some fixes of problematic lockings that did not cause this deadlock.
Part of #994.