-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Convert fileops e2e tests into integration tests. #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
fileops-e2e-to-integration
branch
2 times, most recently
from
February 7, 2023 07:58
36ccd1a
to
abe2ac1
Compare
meowjesty
requested changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you had to deal with go, Tak.
Few notes on the code I've read so far.
t4lz
force-pushed
the
fileops-e2e-to-integration
branch
6 times, most recently
from
February 8, 2023 11:39
3f3e527
to
2349422
Compare
Co-authored-by: meowjesty <43983236+meowjesty@users.noreply.github.com>
t4lz
force-pushed
the
fileops-e2e-to-integration
branch
from
February 8, 2023 13:48
cf1fcf5
to
e713293
Compare
meowjesty
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐻 👍
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
Replace the fileops E2E Go tests with integration tests - separate integration test for each part of the E2E test. Testing with go versions 1.18, 1.19, 1.20. Part of #994.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Convert fileops e2e tests into integration tests.
[Merged by Bors] - Convert fileops e2e tests into integration tests.
Feb 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the fileops E2E Go tests with integration tests - separate integration test for each part of the E2E test.
Testing with go versions 1.18, 1.19, 1.20.
Part of #994.