Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Convert fileops e2e tests into integration tests. #1019

Closed
wants to merge 49 commits into from

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Feb 6, 2023

Replace the fileops E2E Go tests with integration tests - separate integration test for each part of the E2E test.
Testing with go versions 1.18, 1.19, 1.20.

Part of #994.

@t4lz t4lz force-pushed the fileops-e2e-to-integration branch 2 times, most recently from 36ccd1a to abe2ac1 Compare February 7, 2023 07:58
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you had to deal with go, Tak.

Few notes on the code I've read so far.

mirrord/layer/tests/fileops.rs Outdated Show resolved Hide resolved
mirrord/layer/tests/fileops.rs Outdated Show resolved Hide resolved
@t4lz t4lz force-pushed the fileops-e2e-to-integration branch 6 times, most recently from 3f3e527 to 2349422 Compare February 8, 2023 11:39
@t4lz t4lz force-pushed the fileops-e2e-to-integration branch from cf1fcf5 to e713293 Compare February 8, 2023 13:48
Copy link
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻 👍

@t4lz
Copy link
Member Author

t4lz commented Feb 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 8, 2023
Replace the fileops E2E Go tests with integration tests - separate integration test for each part of the E2E test.
Testing with go versions 1.18, 1.19, 1.20.

Part of #994.
@bors
Copy link

bors bot commented Feb 8, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Convert fileops e2e tests into integration tests. [Merged by Bors] - Convert fileops e2e tests into integration tests. Feb 8, 2023
@bors bors bot closed this Feb 8, 2023
@t4lz t4lz mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants