-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CronJob and StatefulSet targetting when copy_target is enabled. #2493
Add CronJob and StatefulSet targetting when copy_target is enabled. #2493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also one thing I missed when reviewing previous JobTarget
PR - we need a feature flag in the operator status to check whether this target type is supported
Issue not found ;/ |
We could trust the |
Yes, job targets should not be listed unless operator supports them |
I'm saying we don't need a feature flag because it either returns it as an option or it doesn't. |
If we want a feature flag for nicer error, I'd make a "target not supported" error with appropriate message and re-use it, as we're adding more and more targets, and it's a bit weird to have a feature flag for each |
Okok, makes sense |
7e7d303
to
fd6428d
Compare
CronJob
as a possibletarget
(requirescopy_target
feature to be enabled);StatefulSet
as a possibletarget
(requirescopy_target
feature to be enabled);