Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous mapping of metadata vs pattern collections #99

Closed
webketje opened this issue Feb 2, 2022 · 0 comments
Closed

Fix ambiguous mapping of metadata vs pattern collections #99

webketje opened this issue Feb 2, 2022 · 0 comments

Comments

@webketje
Copy link
Member

webketje commented Feb 2, 2022

What should the resulting collection property on file metadata look like in the following separate/ mixed configs?
Below is the current config

# collections / location front-matter pattern both
1 'col1' 'col1' [['col1'],'col2']
more ['col1','col2'] ['col1','col2'] ['col1','col2']

There are 2 bugs in 1.2.0:

  • (minor) collection names are not sorted, file metadata collections will come first
  • (major) when multiple collections are added, they will unfortunately be nested arrays

To fix this: add unit tests with multiple mixes of this matrix.

Question: is it safe to assume that users would want pattern- & frontmatter-based collections to be merged? Answer: #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant