Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionController should Compose with PreferencesController #34

Closed
brunobar79 opened this issue Nov 30, 2018 · 2 comments
Closed

TransactionController should Compose with PreferencesController #34

brunobar79 opened this issue Nov 30, 2018 · 2 comments

Comments

@brunobar79
Copy link
Contributor

So the state can only expose the list of transactions for the selected address and current network
@bitpshr
Copy link
Contributor

bitpshr commented Dec 3, 2018

Part of me feels like the TransactionController's state shouldn't be limited to the transactions corresponding to the currently-selected address and the current network. This seems like something that downstream applications should handle when rendering a transaction list if they desire, and that the controller should always maintain all transactions a user has sent.

FWIW, we already only check the current network ID from the NetworkController when updating transaction statuses.

@Gudahtt
Copy link
Member

Gudahtt commented Nov 3, 2021

We are migrating away from the old controller composition system, so this is now obsolete.

@Gudahtt Gudahtt closed this as completed Nov 3, 2021
mcmire pushed a commit to mcmire/core that referenced this issue Jul 17, 2023
@Mrtenz
Add util functions for encoding and decoding bytes (MetaMask#34)
e8035bc 
* Add byte array decoder utils

* Add byte array encoder utils and more tests

* Add tests for hex utils and export missing files

* Add concat function and fix issue in hexToBytes function

* Fix PR comments

* Fix hexToBytes loop

* Use TypeError

* Optimise concat algorithm

* Assert that number is non-negative

* Fix docs

* Add utils for working with signed bigints

* Update docs

* Support uppercase hex prefix and add tests with uppercase characters

* Update comment
kanthesha pushed a commit that referenced this issue Sep 19, 2023
@dependabot
Bump @metamask/auto-changelog from 2.6.1 to 3.0.0 (#34)
d4b7943 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 2.6.1 to 3.0.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v2.6.1...v3.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kanthesha pushed a commit that referenced this issue Oct 11, 2023
@whymarrh
Use acorn@7.1.1 (#34)
41634fd
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 2.6.1 to 3.0.0 (#34)
277aa0b 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 2.6.1 to 3.0.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v2.6.1...v3.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 2.6.1 to 3.0.0 (#34)
e34fc3d 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 2.6.1 to 3.0.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v2.6.1...v3.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this issue Oct 12, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 2.6.1 to 3.0.0 (#34)
3347194 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 2.6.1 to 3.0.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v2.6.1...v3.0.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bitpshr @brunobar79 @Gudahtt @estebanmino