Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ComputedBalanceController #9

Closed
bitpshr opened this issue Jul 30, 2018 · 1 comment
Closed

Port ComputedBalanceController #9

bitpshr opened this issue Jul 30, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@bitpshr
Copy link
Contributor

bitpshr commented Jul 30, 2018

We should port the existing computed balance controller to GABA.

@bitpshr bitpshr added the enhancement New feature or request label Jul 30, 2018
@jennypollack
Copy link
Contributor

computed balances controller isn't used in the extension, we switched to account-tracker and cached-balances-controller

mcmire referenced this issue in mcmire/core Jul 17, 2023
This PR refactors the time utils and adds an `inMilliseconds` function. `Week` and `Year` are added to to the time constants, and the constants are moved to a new `enum`, `Duration`. `inMilliseconds` returns the specified number of units of time, in milliseconds.

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
kanthesha pushed a commit that referenced this issue Sep 19, 2023
kanthesha pushed a commit that referenced this issue Oct 11, 2023
* npm uninstall json-rpc-error

* Move Babel deps into devDependencies
MajorLift pushed a commit that referenced this issue Oct 11, 2023
MajorLift pushed a commit that referenced this issue Oct 11, 2023
MajorLift pushed a commit that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants