Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Container and Footer components #2517

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Add Container and Footer components #2517

merged 2 commits into from
Jun 26, 2024

Conversation

GuillaumeRx
Copy link
Contributor

This PR adds the Footer and Container JSX Components.

  • Footer accepts a single Button or a tuple of two Button
  • Container accepts a single Box or a tuple of a Box and a Footer

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner June 25, 2024 14:29
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (1abcf20) to head (3c215ee).

Current head 3c215ee differs from pull request most recent head 5ce9d77

Please upload reports for the commit 5ce9d77 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files         442      444    +2     
  Lines        9151     9158    +7     
  Branches     1416     1416           
=======================================
+ Hits         8640     8647    +7     
  Misses        511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

david0xd
david0xd previously approved these changes Jun 25, 2024
hmalik88
hmalik88 previously approved these changes Jun 26, 2024
@GuillaumeRx GuillaumeRx merged commit 0a286e1 into main Jun 26, 2024
154 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/jsx-footer branch June 26, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants