Authentication, newline-delimited batches, more tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gianm
commented
Nov 26, 2014
gianm
commented
- Support for basic authentication.
- Support for serializing batches as either arrays or newline-delimited.
- More tests for the HttpPostEmitter and for configuration.
- Fixed some log messages.
- Support for serializing batches as either arrays or newline-delimited. - More tests for the HttpPostEmitter and for configuration. - Fixed some log messages.
| @@ -373,12 +384,16 @@ public void run() | |||
| { | |||
| final List<List<byte[]>> batches = Lists.newLinkedList(); | |||
| List<byte[]> currentBatch = Lists.newArrayList(); | |||
| long currentBatchBytes = 0; | |||
| int currentBatchBytes = 0; | |||
There was a problem hiding this comment.
i hope nobody is sending more than 2G 😆
|
LGTM |
gianm
added a commit
that referenced
this pull request
Jan 28, 2015
Authentication, newline-delimited batches, more tests
|
@b-slim Released emitter-0.2.15 with these changes. Please let us know once you've had a chance to try them out. Thanks! |
|
@gianm Thanks ! sure I will ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.