Create ProfileComponent #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Image didn't upload it seems |
GailWilson
force-pushed
the
gdw/create_profile_component
branch
2 times, most recently
from
6c4599c
to
2a903cf
Compare
|
@carlosdp updated the image |
|
It doesn't look like it's related to this component... What does the app code look like? |
|
yea I'm not seeing what you are, I would need to see the context you are rendering it in |
GailWilson
force-pushed
the
gdw/create_profile_component
branch
from
c795b73
to
f3c52d3
Compare
GailWilson
force-pushed
the
gdw/create_profile_component
branch
from
f3c52d3
to
fc17136
Compare
|
Fixed it! Wrapped a button in a button before 😅 Replacing image with the updated version |
GailWilson
force-pushed
the
gdw/create_profile_component
branch
from
1e0681d
to
c5a4b2f
Compare
carlosdp
reviewed
Dec 31, 2021
src/Button.tsx
Outdated
| @@ -161,4 +172,8 @@ const useStyles = createStyles(theme => ({ | |||
| 'color-secondary': { | |||
| backgroundColor: theme.colors.accent, | |||
| }, | |||
| 'color-unfilled-with-border': { | |||
There was a problem hiding this comment.
unfilled-with-border => unfilled
There was a problem hiding this comment.
This makes sense
| @@ -161,4 +172,8 @@ const useStyles = createStyles(theme => ({ | |||
| 'color-secondary': { | |||
| backgroundColor: theme.colors.accent, | |||
| }, | |||
| 'color-unfilled-with-border': { | |||
| backgroundColor: theme.colors.background, | |||
| border: `2px solid ${theme.colors.onSurface}`, | |||
There was a problem hiding this comment.
i'm going to keep the color of the border here but update to just be unfilled b/c to me the outside border color should be tied to the inside color
carlosdp
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Davatarfor the profile component 🙌