Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Animated InfoCard and update icon to string #4

Merged
merged 5 commits into from
Dec 31, 2021

Conversation

GailWilson
Copy link
Contributor

@GailWilson GailWilson commented Dec 29, 2021

  • Create InfoCard
    -- animated scaling
    -- can be a button or not

  • Updated icon in to be a string instead of component to be more prescriptive on sizing of the image

Problems that still exist due to funky sizing/formats:

  • @gentianmetaphor at some point we definitely should do through the figmas of the components, elements, & flows to make sure the sizing is right when translating here (we can hold off on this later on -- always want to do a design sweep later on too to nit pick the inconsistencies here)

Screenshots

growing animated buttons
disabled info cards

@carlosdp
Copy link
Contributor

  1. Where are those moving shadows coming from?
  2. Should the cards have a background color? Seems weird they are transparent

@gentianmetaphor
Copy link

@GailWilson Yes, I think we need to look at the font sizes across the board, the headers etc seem way bigger, but we can do that later when we have a testing environment setup.

On hover, the card should have a background gradient background 'light grey' 100%-0% opacity.

Screen Shot 2021-12-29 at 10 21 49 AM

.

@GailWilson
Copy link
Contributor Author

Updated the opacity @gentianmetaphor @carlosdp

And @carlosdp, I have no idea what's up with those shadows...i think it was something weird with the gif i recorded...

Screenshot with opacity:
Screen Shot 2021-12-29 at 4 00 31 PM

@carlosdp
Copy link
Contributor

looks good, just merge in master and run git rm -rf --cached dist/ and commit that before merging plz

@carlosdp
Copy link
Contributor

went ahead and did that for you @GailWilson, good to merge!

@GailWilson GailWilson merged commit 22e1083 into master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants