-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESModules import support #325
Conversation
I don't like esmodules but let it be 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
ping @belochub. |
ping @belochub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small suggestion.
6b5af70
to
4cecd62
Compare
PR-URL: #325
Landed in 94df329. |
As it turns out, this PR has introduced a regression by breaking support for importing submodules (e.g. |
Should be fixed with #336. |
npm run fmt
)npm run doc
to regenerate documentation based on comments)Unreleased
header in CHANGELOG.mdAlso, when 'Conditional exports' are no longer experimental the
package.json
could be changed to useto automativally resolve '@metarhia/common' depending on
require
orimport
usage. (without the need to use@metahia/common/module
)/cc @nechaido @tshemsedinov