Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Don't load submodules with not installed optional dependencies
Some packages may have optional dependencies.
If there was an error during loading a submodue, and it's a missing optional dependency error, just skip this submodule.
Closes #1937
2. Skip submodules if they have already been loaded as a part of main module
Example:
some-module
package.json
index.js
submodule.js
The main module exports all from the submodule.
And the submodule exports a function with the same name as a submodule name.
So when loading the submodule,
lib
already have a propertysubmodule
.Closes #1938
npm t
)npm run fmt
)