lib: allow to broadcast events from server #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
force-pushed
the
add-broadcast-to-server
branch
3 times, most recently
from
12c2eb6
to
4f9c0b6
Compare
belochub
reviewed
Aug 1, 2017
test/node/server-broadcast-event.js
Outdated
| } | ||
| }; | ||
|
|
||
| connectAndCheckEvent(test, iface, eventName, eventArgs, callback); |
There was a problem hiding this comment.
You can use for loop here with connectionCount iterations, this will make this test more flexible.
There was a problem hiding this comment.
That's fine with me too.
nechaido
reviewed
Aug 1, 2017
test/node/server-broadcast-event.js
Outdated
| } | ||
| }; | ||
|
|
||
| connectAndCheckEvent(test, iface, eventName, eventArgs, callback); |
There was a problem hiding this comment.
I'd use for loop here and change plan to test.plan(4*connections).
nechaido
requested changes
Aug 1, 2017
test/node/server-broadcast-event.js
Outdated
| const eventName = 'broadcast'; | ||
| const eventArgs = ['hello']; | ||
|
|
||
| test.plan(12); |
nechaido
approved these changes
Aug 2, 2017
lundibundi
force-pushed
the
add-broadcast-to-server
branch
from
c0f7328
to
07b05a0
Compare
lundibundi
force-pushed
the
add-broadcast-to-server
branch
from
07b05a0
to
a902929
Compare
belochub
pushed a commit
that referenced
this pull request
Aug 2, 2017
PR-URL: #287 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
|
Landed in 13f4941. |
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #287 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #287 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com> Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Merged
belochub
added a commit
that referenced
this pull request
Jan 23, 2018
This is a new and shiny first major release for `metarhia-jstp`.
Changes include API refactoring and improvements, implementations of
CLI, sessions, and application versions, native addon build optimizations,
lots of bug fixes, test coverage increase, and other, less notable changes.
This release also denotes the bump of the protocol version to v1.0.
The only difference from the previous version of the protocol is that
"old" heartbeat messages (`{}`) are now deprecated and `ping`/`pong`
messages must be used for this purpose instead.
Notable changes:
* **src,build:** improve the native module subsystem
*(Alexey Orlenko)*
[#36](#36)
**\[semver-minor\]**
* **build:** compile in ISO C++11 mode
*(Alexey Orlenko)*
[#37](#37)
**\[semver-minor\]**
* **build:** improve error handling
*(Alexey Orlenko)*
[#40](#40)
**\[semver-minor\]**
* **lib:** refactor record-serialization.js
*(Alexey Orlenko)*
[#41](#41)
* **parser:** fix a possible memory leak
*(Alexey Orlenko)*
[#44](#44)
**\[semver-minor\]**
* **protocol:** change the format of handshake packets
*(Alexey Orlenko)*
[#54](#54)
**\[semver-major\]**
* **parser:** make parser single-pass
*(Mykola Bilochub)*
[#61](#61)
* **parser:** remove special case for '\0' literal
*(Mykola Bilochub)*
[#68](#68)
**\[semver-major\]**
* **parser:** fix bug causing node to crash
*(Mykola Bilochub)*
[#75](#75)
* **client:** drop redundant callback argument
*(Alexey Orlenko)*
[#104](#104)
**\[semver-major\]**
* **client:** handle errors in connectAndInspect
*(Alexey Orlenko)*
[#105](#105)
**\[semver-major\]**
* **socket,ws:** use socket.destroy() properly
*(Alexey Orlenko)*
[#84](#84)
**\[semver-major\]**
* **cli:** add basic implementation
*(Mykola Bilochub)*
[#107](#107)
**\[semver-minor\]**
* **connection:** fix error handling in optional cbs
*(Alexey Orlenko)*
[#147](#147)
**\[semver-major\]**
* **test:** add JSON5 specs test suite
*(Alexey Orlenko)*
[#158](#158)
* **lib:** change event signature
*(Denys Otrishko)*
[#187](#187)
**\[semver-major\]**
* **lib:** add address method to Server
*(Denys Otrishko)*
[#190](#190)
**\[semver-minor\]**
* **parser:** implement NaN and Infinity parsing
*(Mykola Bilochub)*
[#201](#201)
* **parser:** improve string parsing performance
*(Mykola Bilochub)*
[#220](#220)
* **lib:** optimize connection events
*(Denys Otrishko)*
[#222](#222)
**\[semver-major\]**
* **lib:** refactor server and client API
*(Denys Otrishko)*
[#209](#209)
**\[semver-major\]**
* **lib,src:** rename term packet usages to message
*(Denys Otrishko)*
[#270](#270)
**\[semver-major\]**
* **lib:** emit events about connection messages
*(Denys Otrishko)*
[#252](#252)
**\[semver-minor\]**
* **lib:** implement API versioning
*(Denys Otrishko)*
[#231](#231)
**\[semver-minor\]**
* **lib:** allow to set event handlers in application
*(Denys Otrishko)*
[#286](#286)
**\[semver-minor\]**
* **lib:** allow to broadcast events from server
*(Denys Otrishko)*
[#287](#287)
**\[semver-minor\]**
* **connection:** make callback method private
*(Alexey Orlenko)*
[#306](#306)
**\[semver-major\]**
* **lib:** implement sessions
*(Mykola Bilochub)*
[#289](#289)
**\[semver-major\]**
* **connection:** use ping-pong instead of heartbeat
*(Dmytro Nechai)*
[#303](#303)
**\[semver-major\]**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also contains #284 as it won't work properly without it and #288.