test: add a missing regression test for GH-329

[aqrln]

Add a missing regression test for connectAndInspect with empty array of
interfaces.

[nechaido]

LGTM. Though, should we check that no inspect message is sent?

[aqrln]

@nechaido PTAL

[belochub]

I think it can be better to use server's log event here:

server.on('log', (connection, event) => {
  if (event === 'inspect') {
    inspectSent = true;
  }
});

[aqrln]

@nechaido @belochub I've pushed new commits to address the feedback, PTAL

[nechaido]

LGTM with a nit.
Also there is no need in subtest in this case, so the test may be written this way:

'use strict';
const test = require('tap');
const jstp = require('../..')

const app = new jstp.Application('app', {});
const server = jstp.net.createServer([app]);
server.on('log', (connection, event) => {
  if (event === 'inspect') {
    test.fail('must not send inspect messages');
  }
});

server.listen(0, () => {
  test.plan(4);
  jstp.net.connectAndInspect(
    app.name,
    null,
    [],
    server.address().port,
    (error, connection, api) => {
      test.pass('must invoke the callback');
      test.assertNot(error, 'must connect to server');
      test.equal(
        Object.keys(api).length,
        0,
        'remote proxy object must be empty'
      );
      test.assertNot(inspectSent, 'must not send inspect message');
      connection.close();
      server.close();
    }
  );
});

[nechaido]

This may be misleading, as api is an object that contains RemoteProxy, but remote proxy object may be interpreted as 'instance of RemoteProxy'.

[aqrln]

@nechaido @belochub please take another look

[nechaido]

LGTM

[aqrln]

Unrelated macOS failure:

not ok 30 - test/node/resendable-call-from-client.js # time=241094.551ms
  ---
  timeout: 240000
  file: test/node/resendable-call-from-client.js
  command: /home/travis/.nvm/versions/node/v6.14.3/bin/node
  args:
    - test/node/resendable-call-from-client.js
  stdio:
    - 0
    - pipe
    - 2
  cwd: /home/travis/build/metarhia/jstp
  ...
{
    ok 1 - must connect without errors
    not ok 2 - timeout!
      ---
      signal: SIGTERM
      handles:
        - type: ChildProcess
          events:
            - internalMessage
            - message
        - type: Pipe
        - type: Socket
          events:
            - end
            - finish
            - _socketEnd
            - data
            - error
            - close
      expired: TAP
      stack: |
        emit (node_modules/nyc/node_modules/signal-exit/index.js:77:11)
        process.listener (node_modules/nyc/node_modules/signal-exit/index.js:91:7)
        processEmit (node_modules/nyc/node_modules/signal-exit/index.js:155:32)
        processEmit (node_modules/signal-exit/index.js:155:32)
      test: TAP
      ...
    
    1..2
    # failed 1 of 2 tests
    # time=185627.749ms
    
    not ok 3 - timeout!
      ---
      expired: test/node/resendable-call-from-client.js
      ...
}

[belochub]

Landed in b18215b.