lib,build: use Web Crypto API in browser #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belochub
force-pushed
the
use-browser-web-crypto-api
branch
from
67d77f9
to
dc85ae8
Compare
aqrln
reviewed
Aug 7, 2018
lib/common-crypto-fallback.js
Outdated
| @@ -0,0 +1,42 @@ | |||
| 'use strict'; | |||
|
|
|||
| /*eslint-env browser*/ | |||
lib/common-crypto-fallback.js
Outdated
|
|
||
| /*eslint-env browser*/ | ||
|
|
||
| // Browser adapter for required functions from node.js crypto module. |
lib/common-crypto-fallback.js
Outdated
| crypto = { | ||
| randomBytes(count) { | ||
| const buf = Buffer.alloc(count); | ||
| for (let i = 0; i < count; i++) { |
There was a problem hiding this comment.
Not that essential as it's only three lines of code, but the function below could be reused here.
aqrln
reviewed
Aug 7, 2018
webpack.config.js
Outdated
| @@ -35,6 +35,6 @@ module.exports = { | |||
| net: false, | |||
| tls: false, | |||
| // TODO: support WebCrypto API in lib/common.js and uncomment this | |||
aqrln
approved these changes
Aug 7, 2018
lundibundi
approved these changes
Aug 7, 2018
| ); | ||
| crypto.randomFillSync = (buf) => { | ||
| for (let i = 0; i < buf.length; i++) { | ||
| buf[i] = Math.floor(0x100 * Math.random()); |
There was a problem hiding this comment.
Just a nit but maybe 256 instead of 0x100? Should be clearer.
There was a problem hiding this comment.
@lundibundi, I've specifically used 0x100 to emphasize the fact that the resulting number must fit into a byte.
There was a problem hiding this comment.
I don't see any difference one way or the other. 0x100 seems fine as it is, but no strong opinion.
There was a problem hiding this comment.
Same here, it's just that to me 256 is clearer (the fact that its a byte) than 0x100.
belochub
force-pushed
the
use-browser-web-crypto-api
branch
from
52eec64
to
3118289
Compare
belochub
added a commit
that referenced
this pull request
Aug 8, 2018
PR-URL: #360 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
|
Landed in d77434b. |
belochub
added a commit
that referenced
this pull request
Aug 30, 2018
PR-URL: #360 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.