Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HU transform from HU window #514

Closed
metas-ts opened this issue Jul 20, 2017 · 6 comments
Closed

Support HU transform from HU window #514

metas-ts opened this issue Jul 20, 2017 · 6 comments

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

Feature request

What is the current behavior?

Current problem:

  • often there are more than 100 M_HUs shown in the wewbui HU window
  • if the transform process is selected with a TU or CU, then the action "TU to existing LU" resp. "CU to existing TU" are available.

Now, the problem is that aparently, the auto-complete widget that we enjoy in a generic window is not available in the process parameter window. That means that we only have a (truncated) list which might or might not contain the target LU resp. TU we want to select.

Which are the steps to reproduce?

Try is in master: you will get an exception because the java process coase tries to look up and load all LUs resp. TUs and a deeper part of the system (i.e. HUEditorViewBuffer_HighVolume) rejects to load more than 100 items at once.

I also experimented and changed the processes M_TU_HU_ID and M_LU_HU_ID parameters as follows

  • autocomplete=>Y
  • new validation rule to just show TUs resp LUs

Result: is get still a list of HUs for each respective parameter; no typeahead/autocomplete widget

What is the expected or desired behavior?

I need an auto complete widget. it shall work like the ones we have in generic windows (e.g. to select an M_Product for an order line)

Other alternative we considered: only provide the transform process if there are less than 100 HUs in the currentl selection. This won't work because if the user wants to put a TU onto an LU, they would both need to be in that selection. That's not practical. The target HUs can't be resprcited by the view's selection; the user needs to scan the physical HU's ID and therefore select is as process parameter

metas-ts added a commit that referenced this issue Jul 20, 2017
How to decide if the TU-to-existing-LU and CU-to-existing-TU actions are
available:
* if there are more than 50 rows (typical in the HU window), then assume
that at least one target HU will be among them and provide the action. 
* if there are 50 or less (typical in material receipt), then check

Also, comment out the methods that populate the selection lists for the
target LU resp TU; instead, we provide an AD_Validation_Rule to do the
filtering on AD level 

Support HU transform from HU window
#514
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 20, 2017
changes in WEBUI_HU_Transform process
* autocomplete=>Y
* create and use new validation rules to just show TUs resp LUs

Support HU transform from HU window
metasfresh/metasfresh-webui-api-legacy#514
@metas-mk
Copy link
Member

@metas-ts
about

Now, the problem is that aparently, the auto-complete widget that we enjoy in a generic window is not available in the process parameter window.

We are talking about this widget, right? It's available in general.

image

@metas-ts
Copy link
Member Author

@metas-mk @teosarca
Mark and I compared the AD_Process_Params from
WEBUI_M_HU_Transform => M_LU_HU_ID
and
RV_Fresh_PriceList => C_BPartner_ID

no significant differences..

  • C_BPanter is mandatory and has a default value set, and C_BPArtner_ID doesn't neew an AD_Reference_Value, because it's the actual table's PK
    ...but afaiu there are no "real" diffeerences between the two

teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
teosarca added a commit that referenced this issue Jul 22, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 28, 2017
[#2083](#2083) Window Design WebUI: Customer Returns
[#2069](#2069) Window Design WebUI: Bill of Materials
[#2046](#2046) Window Design WebUI: Attribute Set
[#2092](#2092) Scheduler - improve error handling if AD_Role_ID can't be found
[#1046](metasfresh/metasfresh-webui-frontend-legacy#1046) opening included view from action not working in picking
[#518](metasfresh/metasfresh-webui-api-legacy#518) Picking prototype (v6)
[#1031](metasfresh/metasfresh-webui-frontend-legacy#1031) Autoselect when doubleclick on included Tab Row Field
[#2066](#2066) CRM: Businesspartner B2C Reminder Functionality
[#2067](#2067) switch between C_Order_MFGWarehouse with and without barcode
[#496](metasfresh/metasfresh-webui-api-legacy#496) String document IDs cannot be converted to int Handling Unit Editor
[#1061](metasfresh/metasfresh-webui-frontend-legacy#1061) Larger Avatar Menu Photo
[#1073](metasfresh/metasfresh-webui-frontend-legacy#1073) Bug in Advanced edit of Purchase order
[#1062](metasfresh/metasfresh-webui-frontend-legacy#1062) Avatar Foto stretches when not Square
[#1068](metasfresh/metasfresh-webui-frontend-legacy#1068) board: when there are no new cards show the empty result text/hint
[#1067](metasfresh/metasfresh-webui-frontend-legacy#1067) board: add new: don't show the loading icon after data is loaded
[#1026](metasfresh/metasfresh-webui-frontend-legacy#1026) grid: Get rid of double scrollbar
[#1027](metasfresh/metasfresh-webui-frontend-legacy#1027) line looks selected, but it's not
[#1045](metasfresh/metasfresh-webui-frontend-legacy#1045) frontend shall switch to offline mode on http 503 error
[#503](metasfresh/metasfresh-webui-api-legacy#503) Picking prototype (v5)
[#2042](#2042) Process to Update Widget Size in all child UI Elements of a System Element
[#2019](#2019) Add Widget Size to System Elements
[#516](metasfresh/metasfresh-webui-api-legacy#516) moving 1 TU from one LU to another
[#511](metasfresh/metasfresh-webui-api-legacy#511) Problems with Sales Opportunities Board
[#514](metasfresh/metasfresh-webui-api-legacy#514) Support HU transform from HU window

me-45
@metas-lc metas-lc self-assigned this Aug 9, 2017
@metas-lc
Copy link

metas-lc commented Aug 9, 2017

IT
(don't know if the errors i found are related with this task)

  1. General
  2. HU IDs in HU Editor are autocomplete

I. Receipt Candidates

  1. Receipt Candidates - Receive HUs (receive 3 LUs each with 1 TU)
  2. select a TU - transform, use TU on existing LU
    => only the LUs you have opened are available to choose OK
  3. Open the line again on CUs only
  4. put some on TUs and leave some out
  5. select the CU line and use transform, CU on existing TU
    => only the TUs you have opened are available to choose OK
  6. open hu editor with e.g. 120 LUs, each with 1 TU on each
  7. select a TU, press on transform
  8. select an action => error NOK

Error: Failed invoking private de.metas.ui.web.window.datatypes.LookupValuesList...
Server error
Failed invoking private de.metas.ui.web.window.datatypes.LookupValuesList de.metas.ui.web.handlingunits.process.WEBUI_M_HU_Transform.getActions() using [Ljava.lang.Object;@27e84f61
(note: also tryed with 100 LUs and it works...the available actions in transform just load slow)

II. HU Editor

  1. go to HU Editor end select a random TU, use transform to put it on an existing LU
    => you can search for your LUs value, moves fast OK
    => but you can also select a TU. Is that OK? you get the following error
    Error: Ihr Test hat einen...
    Server error
    Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    Bitte leiten Sie diese Meldung an metas weiter: Error: parentPIItem==null for parentHU=X_M_HU[M_HU_ID=1000691, Value=1000691, trxName=<>] and piOfChildHU=X_M_HU_PI[M_HU_PI_ID=2002659, Name=IFCO 6410, trxName=<>]

  2. go to HU Editor end select a random CU, use transform to put it on existing TU
    => you can also choose an LU but you get this error
    Error: Ihr Test hat einen...
    Server error
    Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    Bitte leiten Sie diese Meldung an metas weiter: Error: Param 'tuHU' does not have one 'MI' item; tuHU=X_M_HU[M_HU_ID=1000000, Value=1000000, trxName=<>]
    is that OK?

Select a TU => error
Error: org.postgresql.util.PSQLException: ERROR: null value...
Server error
org.postgresql.util.PSQLException: ERROR: null value in column "m_hu_id" violates not-null constraint Detail: Failing row contains (1000000, 1000000, 2017-08-09 17:51:35+02, 2188223, Y, null, 1000029, null, null, null, 2017-08-09 17:51:35+02, 2188223, 2017-08-09 17:51:35+02, TRANSFORM_LOAD, null, null, null, 1000697, null, P, 1002026, null, 2005577, -10). SQL: INSERT INTO M_HU_Trace (AD_Client_ID,AD_Org_ID,Created,CreatedBy,EventTime,HUTraceType,IsActive,M_HU_Trace_ID,M_HU_Trx_Line_ID,M_Product_ID,Qty,Updated,UpdatedBy,VHU_ID,VHUStatus) VALUES (1000000,1000000,TO_TIMESTAMP('2017-08-09 17:51:35','YYYY-MM-DD HH24:MI:SS'),2188223,TO_TIMESTAMP('2017-08-09 17:51:35','YYYY-MM-DD HH24:MI:SS'),'TRANSFORM_LOAD','Y',nextval('m_hu_trace_seq'),1002026,2005577,-10,TO_TIMESTAMP('2017-08-09 17:51:35','YYYY-MM-DD HH24:MI:SS'),2188223,1000697,'P') RETURNING M_HU_Trace_ID

III. Issue

  1. manufacturing order -> co-product -> issue
  2. select a TU and use transform
    => you can choose from every active HU (like you would be in HU Editor). Is that wanted?
    => also, you can use LU and TU at the same time, like in Hu Editor cases

@metas-lc
Copy link

metas-lc commented Aug 10, 2017

Recap NOKs:

  1. Receipt Candidates - Receive HUs >= 120 LUs (1 TU each) -> select a TU -> transform -> select action => error
    Failed invoking private de.metas.ui.web.window.datatypes.LookupValuesList...
    Server error
    Failed invoking private de.metas.ui.web.window.datatypes.LookupValuesList de.metas.ui.web.handlingunits.process.WEBUI_M_HU_Transform.getActions() using [Ljava.lang.Object;@27e84f61

  2. go to HU Editor end select a random TU, use transform to put it on an existing LU
    => you can also select a TU. and if you select a TU, you get the following error
    Error: Ihr Test hat einen...
    Server error
    Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    Bitte leiten Sie diese Meldung an metas weiter: Error: parentPIItem==null for parentHU=X_M_HU[M_HU_ID=1000691, Value=1000691, trxName=<>] and piOfChildHU=X_M_HU_PI[M_HU_PI_ID=2002659, Name=IFCO 6410, trxName=<>

  3. same as last step, but CU on TU
    => Error: Ihr Test hat einen...
    Server error
    Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    Bitte leiten Sie diese Meldung an metas weiter: Error: Param 'tuHU' does not have one 'MI' item; tuHU=X_M_HU[M_HU_ID=1000000, Value=1000000, trxName=<>]

  4. (this is a question pending answer) EDIT: WANTED. so it's OK
    Issue -> use transform -> put tu on existing LU -> you can select from all active LUs. OK? or we wanna see only those which are open, there, in the ISSUE?

@metas-lc metas-lc removed their assignment Aug 11, 2017
@teosarca
Copy link
Member

not sure if this is up2date. Pls check it.

@metas-lc
Copy link

  1. could not reproduce
  2. i can still choose a "no packing item" and i get "Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    ↵Bitte leiten Sie diese Meldung an metas weiter:↵↵Error: parentPIItem==null for parentHU=X_M_HU[M_HU_ID=1000031, Value=1000031, trxName=<>] and piOfChildHU=X_M_HU_PI[M_HU_PI_ID=2002659, Name=IFCO 6410, trxName=<>]"
    path:"/rest/api/process/ADP_540763/1007674/start"
  3. same Server error
    Ihr Test hat einen bisher unentdeckten Fehler offengelegt.
    Bitte leiten Sie diese Meldung an metas weiter: Error: parentPIItem==null for parentHU=X_M_HU[M_HU_ID=1000058, Value=1000058, trxName=<>] and piOfChildHU=X_M_HU_PI[M_HU_PI_ID=2002659, Name=IFCO 6410, trxName=<>]

for all 3 i created followup #753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants