Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking prototype (v6) #518

Closed
metas-ts opened this issue Jul 24, 2017 · 4 comments
Closed

Picking prototype (v6) #518

metas-ts opened this issue Jul 24, 2017 · 4 comments

Comments

@metas-ts
Copy link
Member

metas-ts commented Jul 24, 2017

Is this a bug or feature request?

Feature

What is the current behavior?

this is a follow up from #503

Which are the steps to reproduce?

What is the expected or desired behavior?

@metas-ts metas-ts self-assigned this Jul 24, 2017
metas-ts added a commit that referenced this issue Jul 24, 2017
518: Picking prototype (v6)

Task-Url: #518
(cherry picked from commit 21e196c)
metas-ts added a commit that referenced this issue Jul 24, 2017
518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 24, 2017
commit the current not-compiling WIP

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 24, 2017
518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 24, 2017
518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 24, 2017
metas-ts added a commit that referenced this issue Jul 24, 2017
518: Picking prototype (v6)

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 25, 2017
* PickingCandidateCommand: 
solve problem that the HU was created, but no qty was picked; thx
@teosarca
* WEBUI_Picking_PickToNewHU: avoid being called with non-picking-slot
item
* WEBUI_Picking_M_Picking_Candidate_Processed: minor

Task-Url: #518
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 26, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 26, 2017
* IHUShipmentScheduleBL.addQtyPicked updates M_HU.HUStatus to "picked"
* remove IHUContext.NULL to avoid NPEs
* add javadocs, @nonnull etc

518: Picking prototype (v6) 

Task-Url: metasfresh/metasfresh-webui-api-legacy#518
metas-ts added a commit that referenced this issue Jul 26, 2017
* renamed processes
* implement hu candidate unprocessing
* extract AD_Message.Values into a constant class
* add missing AD_Messages (i think i aleady did this :-/)
* add new AD_Messages

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 26, 2017
518: Picking prototype (v6) 

Task-Url: metasfresh/metasfresh-webui-api-legacy#518
metas-ts added a commit that referenced this issue Jul 26, 2017
* support many M_ShipmentSchedule_IDs (packageable lines)
* add javadoc etc

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 26, 2017
also add ad_messages; 

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit that referenced this issue Jul 27, 2017
@metas-ts metas-ts removed their assignment Jul 27, 2017
@metas-ts
Copy link
Member Author

metas-ts commented Jul 27, 2017

Done wrt original description

  • implement "unprocessing" of processed M_Picking_Candidate records
  • assignment (filtering for assignable slots) works

Also done

  • fix: pick to new hu didn't work properly (hu was just created)
  • add i18n messages if a process is not available
  • support picking from many shipment schedules (M_Packageables) into one picking slot
  • M_ShipmentSchedule_QtyPicked is updated and HUs are set to "picked" when the picking candidates status is set "processed" (shipments can be generated at this point)
  • HUs are added to picking slot queue when the picking candidates status is set "closed" (i.e. picking window is closed)

To be clarified

Not (fully) done wrt original description

metas-ts added a commit that referenced this issue Jul 27, 2017
imho this makes it easier to under stand the code..
before: left => Picking; right => pickingSlot
now: left => packageable; right => pickingSlot

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 27, 2017
the validation rule allows to filter for top-level-hus

518: Picking prototype (v6) 

Task-Url: metasfresh/metasfresh-webui-api-legacy#518
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 27, 2017
* the validation rule allows to filter for top-level-hus
* also improve the proces names shown to users

518: Picking prototype (v6)

Task-Url: metasfresh/metasfresh-webui-api-legacy#518
metas-ts added a commit that referenced this issue Jul 27, 2017
* WEBUI_Picking_AddHUToPickingSlot might be useful
* also improve
WEBUI_Picking_RemoveHUFromPickingSlot.checkPreconditionsApplicable()

518: Picking prototype (v6) 

Task-Url: #518
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jul 28, 2017
[#2083](#2083) Window Design WebUI: Customer Returns
[#2069](#2069) Window Design WebUI: Bill of Materials
[#2046](#2046) Window Design WebUI: Attribute Set
[#2092](#2092) Scheduler - improve error handling if AD_Role_ID can't be found
[#1046](metasfresh/metasfresh-webui-frontend-legacy#1046) opening included view from action not working in picking
[#518](metasfresh/metasfresh-webui-api-legacy#518) Picking prototype (v6)
[#1031](metasfresh/metasfresh-webui-frontend-legacy#1031) Autoselect when doubleclick on included Tab Row Field
[#2066](#2066) CRM: Businesspartner B2C Reminder Functionality
[#2067](#2067) switch between C_Order_MFGWarehouse with and without barcode
[#496](metasfresh/metasfresh-webui-api-legacy#496) String document IDs cannot be converted to int Handling Unit Editor
[#1061](metasfresh/metasfresh-webui-frontend-legacy#1061) Larger Avatar Menu Photo
[#1073](metasfresh/metasfresh-webui-frontend-legacy#1073) Bug in Advanced edit of Purchase order
[#1062](metasfresh/metasfresh-webui-frontend-legacy#1062) Avatar Foto stretches when not Square
[#1068](metasfresh/metasfresh-webui-frontend-legacy#1068) board: when there are no new cards show the empty result text/hint
[#1067](metasfresh/metasfresh-webui-frontend-legacy#1067) board: add new: don't show the loading icon after data is loaded
[#1026](metasfresh/metasfresh-webui-frontend-legacy#1026) grid: Get rid of double scrollbar
[#1027](metasfresh/metasfresh-webui-frontend-legacy#1027) line looks selected, but it's not
[#1045](metasfresh/metasfresh-webui-frontend-legacy#1045) frontend shall switch to offline mode on http 503 error
[#503](metasfresh/metasfresh-webui-api-legacy#503) Picking prototype (v5)
[#2042](#2042) Process to Update Widget Size in all child UI Elements of a System Element
[#2019](#2019) Add Widget Size to System Elements
[#516](metasfresh/metasfresh-webui-api-legacy#516) moving 1 TU from one LU to another
[#511](metasfresh/metasfresh-webui-api-legacy#511) Problems with Sales Opportunities Board
[#514](metasfresh/metasfresh-webui-api-legacy#514) Support HU transform from HU window

me-45
@metas-lc
Copy link

metas-lc commented Aug 24, 2017

IT
I. picking regression: don't know if the NOK is related. Please check #503

II. webui picking
(see no. 6. to ask: no. 8)
to test:

  1. create new HU (pick to new hu. New hu is created with the qty you set and added on the picking slot, status planning) OK
  2. add QtyCU to existing HU (select an hu from the picking slot - pick to existing hu - add qty TU => new cu added, TU updated the qty) OK
  3. process to "process" M_Picking_Candidate (IT: exists. You have to select the HU on the picking and go to dropdown: "Process Picking") OK
  4. on "pick HU" the HU editor with prefiltered HUs shall open (very very similar to what happens at "action issue" in manufacturing) - (if it's pick to new HU - OK, only the HUs for your product are selectable. If it's about open hu selection window is nok but i created a task: picking: open hu selection window shall show only relevant products #544) a task + OK
  5. implement HU locking similar with Mfg Issue/Receipt
  6. fix String document IDs cannot be converted to int Handling Unit Editor (IT: String document IDs cannot be converted to int. Still happens if you go to picking, press on "+", select a product and use Pick. But it doesn't happen if you select a CU in HU Editor. So i think i'll create a new task.) NOK
  7. fix UC constraint violation when filtering in picking window (filter for e.g. wh. IT: filtering works fine ) OK
  8. no open/close "flickering" (IT: ) OK
  9. support/use dynamic picking-slot assignment (IT: all picking slots are dynamic and working fine) OK
  10. implement "unprocessing" of processed M_Picking_Candidate records (IT: process picking 2 HUS. One active and one planning. Then use Reactivate picking. On the planning one worked. On the active one didn't: "HU 1000060 hat den Status Active (erfordericher Status ist Picked)") NOK ??
  11. assignment (filtering for assignable slots) (IT: if it's about e.g. slots for bpartner X are shown only for bpartner X, it's OK)
  12. fix: pick to new hu didn't work properly (hu was just created) (IT: hu is created, planning and appeard on picking slot) OK
  13. add i18n messages if a process is not available
  14. support picking from many shipment schedules (M_Packageables) into one picking slot
    M_ShipmentSchedule_QtyPicked is updated and HUs are set to "picked" when the picking candidates status is set "processed" (shipments can be generated at this point) (IT: the active ones remain active and the planning ones are picked) NOK i think
  15. HUs are added to picking slot queue when the picking candidates status is set "closed" (i.e. picking window is closed) (IT: didn't work for me but probably did smth wrong?) NOK?

Question: when you unpick an HU that was planning, should it remain planning (this is how it works now) or should it be destroyed?

@metas-lc metas-lc self-assigned this Aug 25, 2017
@metas-lc
Copy link

  1. was changed and doesn't work like this anymore. Plus, that error doesn't appear when you pick OK
  2. unprocessed worked on an active HU. Could not make a planning one OK
  3. as soon as you process a picked hu, the HU becomes picked, and then you can do inout OK
  4. this changed. See testcases from this task Picking slot Rack System flag metasfresh#2740 OK

@teosarca
Copy link
Member

amen, scnr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants