ViewsRepository: improve logging

#514

src/main/java/de/metas/ui/web/view/ViewsRepository.java

@@ -97,6 +97,10 @@ private void truncateTempTablesIfAllowed()
 			truncateTable(I_T_WEBUI_ViewSelection.Table_Name);
 			truncateTable(I_T_WEBUI_ViewSelectionLine.Table_Name);
 		}
+		else
+		{
+			logger.info("Skip truncating selection tables on startup because not configured");
+		}
 	}
 
 	private static void truncateTable(final String tableName)
@@ -138,7 +142,6 @@ private void registerAnnotatedFactories(final Collection<IViewFactory> viewFacto
 				logger.info("Registered {} for windowId={}, viewType={}", factory, windowId, viewTypes);
 			}
 		}
-
 	}
 
 	private final IViewFactory getFactory(final WindowId windowId, final JSONViewDataType viewType)
@@ -163,6 +166,9 @@ private static final ArrayKey mkFactoryKey(final WindowId windowId, final JSONVi
 		return ArrayKey.of(windowId, viewType);
 	}
 
+	/**
+	 * @param viewsIndexStorages view index storages discovered in spring context
+	 */
 	@Autowired
 	private void registerViewsIndexStorages(final Collection<IViewsIndexStorage> viewsIndexStorages)
 	{
@@ -210,7 +216,8 @@ private Stream<IView> streamAllViews()
 	@Override
 	public ViewLayout getViewLayout(final WindowId windowId, final JSONViewDataType viewDataType)
 	{
-		DocumentPermissionsHelper.assertWindowAccess(windowId, null, UserSession.getCurrentPermissions());
+		final String viewId = null; // N/A
+		DocumentPermissionsHelper.assertViewAccess(windowId, viewId, UserSession.getCurrentPermissions());
 
 		final IViewFactory factory = getFactory(windowId, viewDataType);
 		return factory.getViewLayout(windowId, viewDataType)
@@ -229,6 +236,8 @@ public List<IView> getViews()
 	@Override
 	public IView createView(final CreateViewRequest request)
 	{
+		logger.trace("Creating new view from {}", request);
+
 		final WindowId windowId = request.getWindowId();
 		final JSONViewDataType viewType = request.getViewType();
 		final IViewFactory factory = getFactory(windowId, viewType);
@@ -241,13 +250,16 @@ public IView createView(final CreateViewRequest request)
 		}
 
 		getViewsStorageFor(view.getViewId()).put(view);
+		logger.trace("Created view {}", view);
 
 		return view;
 	}
 
 	@Override
 	public IView filterView(final ViewId viewId, final JSONFilterViewRequest jsonRequest)
 	{
+		logger.trace("Creating filtered view from {} using {}", viewId, jsonRequest);
+
 		// Get current view
 		final IView view = getView(viewId);
 
@@ -269,6 +281,11 @@ public IView filterView(final ViewId viewId, final JSONFilterViewRequest jsonReq
 		if (view != newView)
 		{
 			getViewsStorageFor(newView.getViewId()).put(newView);
+			logger.trace("Created filtered view {}", newView);
+		}
+		else
+		{
+			logger.trace("Filtered view is the same as the ordiginal. Returning the original {}", view);
 		}
 
 		// Return the newly created view
@@ -278,6 +295,8 @@ public IView filterView(final ViewId viewId, final JSONFilterViewRequest jsonReq
 	@Override
 	public IView deleteStickyFilter(final ViewId viewId, final String filterId)
 	{
+		logger.trace("Deleting sticky filter {} from {}", filterId, viewId);
+
 		// Get current view
 		final IView view = getView(viewId);
 
@@ -299,6 +318,11 @@ public IView deleteStickyFilter(final ViewId viewId, final String filterId)
 		if (view != newView)
 		{
 			getViewsStorageFor(newView.getViewId()).put(newView);
+			logger.trace("Sticky filter deleted. Returning new view {}", newView);
+		}
+		else
+		{
+			logger.trace("Sticky filter NOT deleted. Returning current view {}", view);
 		}
 
 		// Return the newly created view
@@ -336,12 +360,14 @@ public IView getViewIfExists(final ViewId viewId)
 	public void deleteView(final ViewId viewId)
 	{
 		getViewsStorageFor(viewId).removeById(viewId);
+		logger.trace("Removed view {}", viewId);
 	}
 
 	@Override
 	public void invalidateView(final ViewId viewId)
 	{
 		getViewsStorageFor(viewId).invalidateView(viewId);
+		logger.trace("Invalided view {}", viewId);
 	}
 
 	@Override
@@ -350,6 +376,7 @@ public void notifyRecordsChanged(final Set<TableRecordReference> recordRefs)
 	{
 		if (recordRefs.isEmpty())
 		{
+			logger.trace("No changed records provided. Skip notifying views.");
 			return;
 		}
 
@@ -360,10 +387,6 @@ public void notifyRecordsChanged(final Set<TableRecordReference> recordRefs)
 					notifiedCount.incrementAndGet();
 				});
 
-		if (logger.isDebugEnabled())
-		{
-			logger.debug("Notified {} views about changed records: {}", notifiedCount, recordRefs);
-		}
-
+		logger.debug("Notified {} views about changed records: {}", notifiedCount, recordRefs);
 	}
 }