Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't save a new partner #639

Closed
cristinamghita opened this issue Oct 20, 2017 · 2 comments
Closed

Can't save a new partner #639

cristinamghita opened this issue Oct 20, 2017 · 2 comments
Labels
branch:master branch:release type:bug

Comments

@cristinamghita
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

  • The partner is not saved

Which are the steps to reproduce?

  • create a new partner
  • the partner is not saved
    image
    And see trace:

java.lang.NullPointerException: null
    at de.metas.ui.web.window.model.sql.SqlDocumentsRepository.saveLabels(SqlDocumentsRepository.java:910)
    at de.metas.ui.web.window.model.sql.SqlDocumentsRepository.lambda$0(SqlDocumentsRepository.java:523)
    at de.metas.ui.web.window.model.sql.SqlDocumentsRepository.lambda$1(SqlDocumentsRepository.java:553)
    at java.util.ArrayList.forEach(ArrayList.java:1249)
    at de.metas.ui.web.window.model.sql.SqlDocumentsRepository.save(SqlDocumentsRepository.java:553)
    at de.metas.ui.web.window.model.Document.saveIfHasChanges(Document.java:1850)
    at de.metas.ui.web.window.model.Document.saveIfValidAndHasChanges(Document.java:1831)
    at de.metas.ui.web.window.model.DocumentCollection.commitRootDocument(DocumentCollection.java:378)
    at de.metas.ui.web.window.model.DocumentCollection.forRootDocumentWritable(DocumentCollection.java:300)
    at de.metas.ui.web.window.model.DocumentCollection.forDocumentWritable(DocumentCollection.java:229)
    at de.metas.ui.web.window.controller.WindowRestController.patchDocument0(WindowRestController.java:313)
    at de.metas.ui.web.window.controller.WindowRestController.lambda$8(WindowRestController.java:307)
    at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$4.call(TrxCallableWrappers.java:193)
    at org.adempiere.ad.trx.api.impl.TrxCallableWrappers$5.call(TrxCallableWrappers.java:222)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call0(AbstractTrxManager.java:771)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:683)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:584)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:515)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:492)
    at org.adempiere.ad.trx.api.impl.AbstractTrxManager.call(AbstractTrxManager.java:469)
    at de.metas.ui.web.window.controller.Execution$ExecutionBuilder.lambda$0(Execution.java:194)
    at de.metas.ui.web.window.controller.Execution$ExecutionBuilder.lambda$2(Execution.java:237)
    at de.metas.ui.web.window.controller.Execution$ExecutionBuilder.execute(Execution.java:260)
    at de.metas.ui.web.window.controller.Execution.callInNewExecution(Execution.java:88)
    at de.metas.ui.web.window.controller.WindowRestController.patchDocument(WindowRestController.java:307)
    at de.metas.ui.web.window.controller.WindowRestController.patchRootDocument(WindowRestController.java:276)

What is the expected or desired behavior?

  • The partner shall be saved
@cristinamghita cristinamghita self-assigned this Oct 20, 2017
@cristinamghita cristinamghita mentioned this issue Oct 20, 2017
Closed
cristinamghita added a commit that referenced this issue Oct 20, 2017
@cristinamghita
#639 Fix NPE
9e2d974 
#639 Can't save a new partner
@cristinamghita cristinamghita mentioned this issue Oct 20, 2017
Merged
teosarca added a commit that referenced this issue Oct 20, 2017
@teosarca
Merge pull request #640 from metasfresh/gh639
addf0f4 
#639 Fix NPE
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 22, 2017
@metas-ts
Update ReleaseNotes.md
7bb48b2 
[#2761](#2761) Window Partner dist orgs: link using dropship partner
[#1317](#1317) AD_ChangeLog: don't log Updated and UpdatedBy
[#2766](#2766) add description in c_doctype_trl
[#2784](#2784) Partner Import : Add fields address3 and address4
[#1263](metasfresh/metasfresh-webui-frontend-legacy#1263) Row not selected and no actions after closing the modal view
[#480](#480) Co-Product improvement in Manufacturing
[#1258](metasfresh/metasfresh-webui-frontend-legacy#1258) Opening a new included view is broken (again)
[#2786](#2786) Drop org.adempiere.model.virtualColumn legacy functionality
[#2564](#2564) Concept for entering multiple discounts for order and subscription
[#2311](#2311) Customer Invoices and Invoice Candidates adjustments
[#1281](metasfresh/metasfresh-webui-frontend-legacy#1281) Translations of Photo Widget in User Window
[#2763](#2763) New Window Picking Tray Clearing
[#1249](metasfresh/metasfresh-webui-frontend-legacy#1249) included view: blurWhenOpen support
[#1275](metasfresh/metasfresh-webui-frontend-legacy#1275) Scrolling in Modal window throws errors
[#2768](#2768) Translate window for process "Change Password" into EN
[#625](metasfresh/metasfresh-webui-api-legacy#625) WebUI Scheduler Window Log Subtab: Invalid Client ID=0
[#1248](metasfresh/metasfresh-webui-frontend-legacy#1248) included view: wrong selectedIds when calling quickActions
[#639](metasfresh/metasfresh-webui-api-legacy#639) Can't save a new partner
[#2774](#2774) Vendor Invoice Layout and Translations in WebUI
[#1268](metasfresh/metasfresh-webui-frontend-legacy#1268) Sitemap broken
[#1227](metasfresh/metasfresh-webui-frontend-legacy#1227) The Letter window dissapears after Print Preview
[#1278](metasfresh/metasfresh-webui-frontend-legacy#1278) Shortcuts for New, Batch and Expand are broken
[#2755](#2755) error on hu changing status from shipped to active
[#1271](metasfresh/metasfresh-webui-frontend-legacy#1271) Open ANY included view broken
[#2769](#2769) model generator: wrong columns are generated
[#2750](#2750) Flatrate Import: Support tax category
[#2752](#2752) Inherit C_Taxcategory_ID and IsTaxIncluded from orderline to FT
[#2751](#2571) Report Translations to en_US: menu reports
[#2379](#2379) Procurement Candidates generate Purchase Order
[#2739](#2739) Add context into if exception happens in WorkpackageProcessorTask.processWorkpackage
[#637](metasfresh/metasfresh-webui-api-legacy#637) Move Picking Tray Clearing Functionality to new window
[#472](#472) Picking from Handling Unit Editor (WebUI)
[#1092](metasfresh/metasfresh-webui-frontend-legacy#1092) Prepare Update to React 16
[#1223](metasfresh/metasfresh-webui-frontend-legacy#1223) Scrollbar missing in Handling Unit Editor after "Internal Usage Action"
[#2726](#2726) Set correct identifiers in the table M_ShipmentSchedule (v2)
[#2731](#2731) Window Design Webui: Improve window Shipment Restrictions
[#2732](#2732) Window Design Webui : Add description field in sales order line
[#2725](#2725) Webui Window Design: Improvements in window ESR Payment Import
[#2728](#2728) Webui Design Window: Add Translations to Business Partner
[#2653](#2653) Window Design Webui: Improve Businesspartner Dist-Orgs window
[#2729](#2729) Window Design Webui: Add missing fields to window Tourversion
[#2240](#2240) npe on zoom into header aggregation
[#2730](#2730) Window Design Webui: Improvements in window Purchase order
[#2740](#2740) Picking slot Rack System flag
[#632](metasfresh/metasfresh-webui-api-legacy#632) HU-Trace: show all connected records

me-73
@metas-dh
Copy link
Member

Results of IT1
tested n mf15

  • new bpartner is saved: OK
  • if you start creating the bpartner by adding sth to the search key first, then the brackets remain there after saving, e.g.: search key: "new BP<1000005>"
    => is that OK?

@teosarca
Copy link
Member

IMHO it's OK because if the search key does not start with "<" and ends with ">" the system won't touch it.

So, if the BP was correctly saved in DB then it's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @cristinamghita @metas-dh