Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Row not selected and no actions after closing the modal view #1263

Closed
teosarca opened this issue Oct 16, 2017 · 4 comments
Closed

Row not selected and no actions after closing the modal view #1263

teosarca opened this issue Oct 16, 2017 · 4 comments
Assignees
@ottosichert
Labels
branch:master branch:release priority:high type:bug

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Which are the steps to reproduce?

  • open picking terminal: https://w101.metasfresh.com:8443/window/540345
  • make sure a row is selected (e.g. first one) and call "Pick" action
  • => the modal is opened
  • close the modal and remark: previously selected row is no longer selected

See:
image

There are to quickActions calls:

  1. http://localhost:8080/rest/api/documentView/540345/540345-3d89b700e6974ceea1dbb44d0ce6ef32/quickActions
  2. http://localhost:8080/rest/api/documentView/540350/540350-a1efd47ecb3e4d728b5d1f5a6fd43cf6/quickActions?selectedIds=1000000

The first one has the correct WindowId but it has no selection because there is no row selected.
The second one is for the modal view we just closed. That one shall not be called.

What is the expected or desired behavior?

After closing the modal view, previous selected row or rows shall be preserved.
Correct actions for current selection shall be displayed.
@ottosichert
Copy link
Contributor

This will conflict with #1264, so I will wait until it is reviewed and merged

This was referenced Oct 16, 2017
Closed
Merged
@metas-lc metas-lc self-assigned this Oct 20, 2017
@metas-lc
Copy link

IT

  1. go to picking terminal: https://mf15cloudit/window/540345?page=1&viewId=540345-9c1fc7e4e85b49bf8bc8d5e4218d4ab8
  2. select a line, pick
  3. don't do anything, just press done
    => your line is still selected OK
    => but quickactions don't appear in Network NOK
    picking_no_quickactions
  4. select the other line, and select your line again
    => quickactions appear OK
    picking_quickactions

we want step 3 to have quickaktions shown like in step 4 (for the selected line)

@teosarca
Copy link
Member Author

i.e. after closing the modal we have to re-query the quick actions because they might be changed.

@metas-ts metas-ts assigned ottosichert and unassigned ottosichert and metas-lc Oct 22, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 22, 2017
@metas-ts
Update ReleaseNotes.md
7bb48b2 
[#2761](#2761) Window Partner dist orgs: link using dropship partner
[#1317](#1317) AD_ChangeLog: don't log Updated and UpdatedBy
[#2766](#2766) add description in c_doctype_trl
[#2784](#2784) Partner Import : Add fields address3 and address4
[#1263](metasfresh/metasfresh-webui-frontend-legacy#1263) Row not selected and no actions after closing the modal view
[#480](#480) Co-Product improvement in Manufacturing
[#1258](metasfresh/metasfresh-webui-frontend-legacy#1258) Opening a new included view is broken (again)
[#2786](#2786) Drop org.adempiere.model.virtualColumn legacy functionality
[#2564](#2564) Concept for entering multiple discounts for order and subscription
[#2311](#2311) Customer Invoices and Invoice Candidates adjustments
[#1281](metasfresh/metasfresh-webui-frontend-legacy#1281) Translations of Photo Widget in User Window
[#2763](#2763) New Window Picking Tray Clearing
[#1249](metasfresh/metasfresh-webui-frontend-legacy#1249) included view: blurWhenOpen support
[#1275](metasfresh/metasfresh-webui-frontend-legacy#1275) Scrolling in Modal window throws errors
[#2768](#2768) Translate window for process "Change Password" into EN
[#625](metasfresh/metasfresh-webui-api-legacy#625) WebUI Scheduler Window Log Subtab: Invalid Client ID=0
[#1248](metasfresh/metasfresh-webui-frontend-legacy#1248) included view: wrong selectedIds when calling quickActions
[#639](metasfresh/metasfresh-webui-api-legacy#639) Can't save a new partner
[#2774](#2774) Vendor Invoice Layout and Translations in WebUI
[#1268](metasfresh/metasfresh-webui-frontend-legacy#1268) Sitemap broken
[#1227](metasfresh/metasfresh-webui-frontend-legacy#1227) The Letter window dissapears after Print Preview
[#1278](metasfresh/metasfresh-webui-frontend-legacy#1278) Shortcuts for New, Batch and Expand are broken
[#2755](#2755) error on hu changing status from shipped to active
[#1271](metasfresh/metasfresh-webui-frontend-legacy#1271) Open ANY included view broken
[#2769](#2769) model generator: wrong columns are generated
[#2750](#2750) Flatrate Import: Support tax category
[#2752](#2752) Inherit C_Taxcategory_ID and IsTaxIncluded from orderline to FT
[#2751](#2571) Report Translations to en_US: menu reports
[#2379](#2379) Procurement Candidates generate Purchase Order
[#2739](#2739) Add context into if exception happens in WorkpackageProcessorTask.processWorkpackage
[#637](metasfresh/metasfresh-webui-api-legacy#637) Move Picking Tray Clearing Functionality to new window
[#472](#472) Picking from Handling Unit Editor (WebUI)
[#1092](metasfresh/metasfresh-webui-frontend-legacy#1092) Prepare Update to React 16
[#1223](metasfresh/metasfresh-webui-frontend-legacy#1223) Scrollbar missing in Handling Unit Editor after "Internal Usage Action"
[#2726](#2726) Set correct identifiers in the table M_ShipmentSchedule (v2)
[#2731](#2731) Window Design Webui: Improve window Shipment Restrictions
[#2732](#2732) Window Design Webui : Add description field in sales order line
[#2725](#2725) Webui Window Design: Improvements in window ESR Payment Import
[#2728](#2728) Webui Design Window: Add Translations to Business Partner
[#2653](#2653) Window Design Webui: Improve Businesspartner Dist-Orgs window
[#2729](#2729) Window Design Webui: Add missing fields to window Tourversion
[#2240](#2240) npe on zoom into header aggregation
[#2730](#2730) Window Design Webui: Improvements in window Purchase order
[#2740](#2740) Picking slot Rack System flag
[#632](metasfresh/metasfresh-webui-api-legacy#632) HU-Trace: show all connected records

me-73
@ottosichert ottosichert mentioned this issue Oct 29, 2017
Merged
@metas-dh
Copy link
Member

Results of IT2
tested in mf15

repeated testcase from IT above:

  • previous selected row is preserved after closing modal view: OK
  • correct actions are displayed for the selected line: OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ottosichert ottosichert

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@teosarca @ottosichert @metas-ts @pablosichert @metas-lc @metas-dh