Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Prepare Update to React 16 #1092

Closed
metasnw opened this issue Jul 28, 2017 · 9 comments
Closed

Prepare Update to React 16 #1092

metasnw opened this issue Jul 28, 2017 · 9 comments
Labels
branch:master branch:release type:enhancement
Milestone
Backlog

Comments

@metasnw
Copy link
Member

metasnw commented Jul 28, 2017

Type of issue

Feature request

Current behavior

using React 15

Expected behavior

be ready for 16

Steps to reproduce
@cadavre
Copy link
Contributor

cadavre commented Jul 28, 2017

facebook/react#10294

Most important: read BC and review on required changes on metasfresh-webui-frontend.

@wiadev
Copy link
Contributor

wiadev commented Jul 28, 2017

React 16 is marked with "next" tag, since it has some potential upgrade paths which might cause difficulties.
Still not stable, and not even release. Somewhere between beta and RC.

So it's not couple clicks job to upgrade (has some risks).

Benefits are not quite clear to do immediate update.
I'd suggest to wait until final specs will be available.

@metasnw
Copy link
Member Author

metasnw commented Jul 28, 2017

ok. so lets wait

@metasnw metasnw added this to the Backlog milestone Jul 28, 2017
@pablosichert
Copy link
Contributor

React 16 released 🎉.

Upgrade path from 15.5 should be straightforward when no deprecation warnings are apparent.

@pablosichert pablosichert mentioned this issue Oct 15, 2017
Merged
@teosarca
Copy link
Member

note to IT:

  • webui regression needed
  • check file attachments

@pablosichert
Copy link
Contributor

Addition:

  • check that selection in dropdowns works
  • check that clicking around in tables works
  • check that clicking native controls (inputs, buttons, checkboxes, ...) when they don't expect any action doesn't break the app

@teosarca
Copy link
Member

hi @pablosichert

found this issue: go to sitemap: https://w101.metasfresh.com:8443/sitemap
image

@pablosichert pablosichert mentioned this issue Oct 17, 2017
Closed
@pablosichert
Copy link
Contributor

Also related issue (app not refreshing after getting translation data):

image

@pablosichert pablosichert mentioned this issue Oct 17, 2017
Merged
@teosarca teosarca mentioned this issue Oct 19, 2017
Closed
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 22, 2017
@metas-ts
Update ReleaseNotes.md
7bb48b2 
[#2761](#2761) Window Partner dist orgs: link using dropship partner
[#1317](#1317) AD_ChangeLog: don't log Updated and UpdatedBy
[#2766](#2766) add description in c_doctype_trl
[#2784](#2784) Partner Import : Add fields address3 and address4
[#1263](metasfresh/metasfresh-webui-frontend-legacy#1263) Row not selected and no actions after closing the modal view
[#480](#480) Co-Product improvement in Manufacturing
[#1258](metasfresh/metasfresh-webui-frontend-legacy#1258) Opening a new included view is broken (again)
[#2786](#2786) Drop org.adempiere.model.virtualColumn legacy functionality
[#2564](#2564) Concept for entering multiple discounts for order and subscription
[#2311](#2311) Customer Invoices and Invoice Candidates adjustments
[#1281](metasfresh/metasfresh-webui-frontend-legacy#1281) Translations of Photo Widget in User Window
[#2763](#2763) New Window Picking Tray Clearing
[#1249](metasfresh/metasfresh-webui-frontend-legacy#1249) included view: blurWhenOpen support
[#1275](metasfresh/metasfresh-webui-frontend-legacy#1275) Scrolling in Modal window throws errors
[#2768](#2768) Translate window for process "Change Password" into EN
[#625](metasfresh/metasfresh-webui-api-legacy#625) WebUI Scheduler Window Log Subtab: Invalid Client ID=0
[#1248](metasfresh/metasfresh-webui-frontend-legacy#1248) included view: wrong selectedIds when calling quickActions
[#639](metasfresh/metasfresh-webui-api-legacy#639) Can't save a new partner
[#2774](#2774) Vendor Invoice Layout and Translations in WebUI
[#1268](metasfresh/metasfresh-webui-frontend-legacy#1268) Sitemap broken
[#1227](metasfresh/metasfresh-webui-frontend-legacy#1227) The Letter window dissapears after Print Preview
[#1278](metasfresh/metasfresh-webui-frontend-legacy#1278) Shortcuts for New, Batch and Expand are broken
[#2755](#2755) error on hu changing status from shipped to active
[#1271](metasfresh/metasfresh-webui-frontend-legacy#1271) Open ANY included view broken
[#2769](#2769) model generator: wrong columns are generated
[#2750](#2750) Flatrate Import: Support tax category
[#2752](#2752) Inherit C_Taxcategory_ID and IsTaxIncluded from orderline to FT
[#2751](#2571) Report Translations to en_US: menu reports
[#2379](#2379) Procurement Candidates generate Purchase Order
[#2739](#2739) Add context into if exception happens in WorkpackageProcessorTask.processWorkpackage
[#637](metasfresh/metasfresh-webui-api-legacy#637) Move Picking Tray Clearing Functionality to new window
[#472](#472) Picking from Handling Unit Editor (WebUI)
[#1092](metasfresh/metasfresh-webui-frontend-legacy#1092) Prepare Update to React 16
[#1223](metasfresh/metasfresh-webui-frontend-legacy#1223) Scrollbar missing in Handling Unit Editor after "Internal Usage Action"
[#2726](#2726) Set correct identifiers in the table M_ShipmentSchedule (v2)
[#2731](#2731) Window Design Webui: Improve window Shipment Restrictions
[#2732](#2732) Window Design Webui : Add description field in sales order line
[#2725](#2725) Webui Window Design: Improvements in window ESR Payment Import
[#2728](#2728) Webui Design Window: Add Translations to Business Partner
[#2653](#2653) Window Design Webui: Improve Businesspartner Dist-Orgs window
[#2729](#2729) Window Design Webui: Add missing fields to window Tourversion
[#2240](#2240) npe on zoom into header aggregation
[#2730](#2730) Window Design Webui: Improvements in window Purchase order
[#2740](#2740) Picking slot Rack System flag
[#632](metasfresh/metasfresh-webui-api-legacy#632) HU-Trace: show all connected records

me-73
@teosarca
Copy link
Member

this task is IN from October and no complains. Moving it to done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@cadavre @teosarca @metas-ts @pablosichert @metasnw @wiadev