Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Opening a new included view is broken (again) #1258

Closed
teosarca opened this issue Oct 14, 2017 · 9 comments
Closed

Opening a new included view is broken (again) #1258

teosarca opened this issue Oct 14, 2017 · 9 comments

Comments

@teosarca
Copy link
Member

see #1243

@teosarca
Copy link
Member Author

After pressing the "Open HU Selection..." action, nothing happens even though the HU's view layout and data is fetched (windowId=540189).

image

@ottosichert
Copy link
Contributor

Note: This will most likely conflict with #1264 (same as #1263 (comment))

@metas-lc
Copy link

metas-lc commented Oct 20, 2017

IT

  1. go to picking slots window, select a line, pick
  2. select a picking slots, open hu selection window
    => included view opens OK
  3. select an hu and press on "pick HU"
    => only once, i got this (see pic), rest of the time i could see the picking slots, but for a very short time, like 0.5s i could see like in pic (don't know if it's related with the error)

picking_empty_hus

is this related with this task?

@ottosichert
Copy link
Contributor

See my comment in PR #1282 (comment). I am still waiting for feedback on this one, but I assume this should work...

I tried following steps:

  • Open Picking Terminal (https://w101.metasfresh.com:8443/window/540345)
  • Select first item
  • Click quick action Pick
  • Modal opens
  • First item in table and includedView is already selected
  • Click quick action Open HU selection window
  • Select a TU in new includedView
  • Uncaught Error: InvalidStateError: The connection has not been established yet

I this supposed to work?

  • Open Picking Terminal (https://w101.metasfresh.com:8443/window/540345)
  • Select first item
  • Click quick action Pick
  • Modal opens
  • First item in table and includedView is already selected
  • Click drop down of quick actions
  • Click Pick to new HU
  • Select item in Packvorschrift-Produkt Zuordnung
  • Click Start
  • Selected item appears below item in includedView

Is this correct?

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 22, 2017
[#2761](#2761) Window Partner dist orgs: link using dropship partner
[#1317](#1317) AD_ChangeLog: don't log Updated and UpdatedBy
[#2766](#2766) add description in c_doctype_trl
[#2784](#2784) Partner Import : Add fields address3 and address4
[#1263](metasfresh/metasfresh-webui-frontend-legacy#1263) Row not selected and no actions after closing the modal view
[#480](#480) Co-Product improvement in Manufacturing
[#1258](metasfresh/metasfresh-webui-frontend-legacy#1258) Opening a new included view is broken (again)
[#2786](#2786) Drop org.adempiere.model.virtualColumn legacy functionality
[#2564](#2564) Concept for entering multiple discounts for order and subscription
[#2311](#2311) Customer Invoices and Invoice Candidates adjustments
[#1281](metasfresh/metasfresh-webui-frontend-legacy#1281) Translations of Photo Widget in User Window
[#2763](#2763) New Window Picking Tray Clearing
[#1249](metasfresh/metasfresh-webui-frontend-legacy#1249) included view: blurWhenOpen support
[#1275](metasfresh/metasfresh-webui-frontend-legacy#1275) Scrolling in Modal window throws errors
[#2768](#2768) Translate window for process "Change Password" into EN
[#625](metasfresh/metasfresh-webui-api-legacy#625) WebUI Scheduler Window Log Subtab: Invalid Client ID=0
[#1248](metasfresh/metasfresh-webui-frontend-legacy#1248) included view: wrong selectedIds when calling quickActions
[#639](metasfresh/metasfresh-webui-api-legacy#639) Can't save a new partner
[#2774](#2774) Vendor Invoice Layout and Translations in WebUI
[#1268](metasfresh/metasfresh-webui-frontend-legacy#1268) Sitemap broken
[#1227](metasfresh/metasfresh-webui-frontend-legacy#1227) The Letter window dissapears after Print Preview
[#1278](metasfresh/metasfresh-webui-frontend-legacy#1278) Shortcuts for New, Batch and Expand are broken
[#2755](#2755) error on hu changing status from shipped to active
[#1271](metasfresh/metasfresh-webui-frontend-legacy#1271) Open ANY included view broken
[#2769](#2769) model generator: wrong columns are generated
[#2750](#2750) Flatrate Import: Support tax category
[#2752](#2752) Inherit C_Taxcategory_ID and IsTaxIncluded from orderline to FT
[#2751](#2571) Report Translations to en_US: menu reports
[#2379](#2379) Procurement Candidates generate Purchase Order
[#2739](#2739) Add context into if exception happens in WorkpackageProcessorTask.processWorkpackage
[#637](metasfresh/metasfresh-webui-api-legacy#637) Move Picking Tray Clearing Functionality to new window
[#472](#472) Picking from Handling Unit Editor (WebUI)
[#1092](metasfresh/metasfresh-webui-frontend-legacy#1092) Prepare Update to React 16
[#1223](metasfresh/metasfresh-webui-frontend-legacy#1223) Scrollbar missing in Handling Unit Editor after "Internal Usage Action"
[#2726](#2726) Set correct identifiers in the table M_ShipmentSchedule (v2)
[#2731](#2731) Window Design Webui: Improve window Shipment Restrictions
[#2732](#2732) Window Design Webui : Add description field in sales order line
[#2725](#2725) Webui Window Design: Improvements in window ESR Payment Import
[#2728](#2728) Webui Design Window: Add Translations to Business Partner
[#2653](#2653) Window Design Webui: Improve Businesspartner Dist-Orgs window
[#2729](#2729) Window Design Webui: Add missing fields to window Tourversion
[#2240](#2240) npe on zoom into header aggregation
[#2730](#2730) Window Design Webui: Improvements in window Purchase order
[#2740](#2740) Picking slot Rack System flag
[#632](metasfresh/metasfresh-webui-api-legacy#632) HU-Trace: show all connected records

me-73
@metas-lc
Copy link

IT
checked on w101 and it works fine.
Can you please take a look here as well?
https://mf15cloudit/window/540345?viewId=540345-dcc1b993d93c4148a3ac3d4531043acb&page=1
it's the only place where is happening and i don't know why
somehow, after you pick, the selected id is for picking slot (ok), but right after the Hu i already picked is selected again and i get empty HUs
steps:

  1. open picking, select a line, use Pick:
    picking1
  2. open hu selection window:
    picking2
  3. pick HU
    picking3
  4. result:
    picking4

@ottosichert
Copy link
Contributor

@metas-lc I cannot reproduce this issue.

This is what I get when I follow your steps:

  1. open picking, select a line, use Pick
  2. open hu selection window
  3. pick HU
  4. result:
    I get back to the same screen as your step 1:
    picking1
    My network requests (different from your network requests!):
    bildschirmfoto vom 2017-10-29 13-39-51

@teosarca
Copy link
Member Author

weird, i've also checked using frontend(latest master) running on my laptop but connecting to mf15cloudit and works.
image

@metas-lc
Copy link

i'll close this task, since it's not a dev issue. I'll keep an eye on it.

@ottosichert
Copy link
Contributor

When I was working on the first PR (#1282), I had the same issue as you mentioned in your first comment (#1258 (comment)) and showed us on your screenshot.

Now my network requests for this process were different than yours and I don't know about @teosarca's setup.

So just a note if this can be reproduced in the future: It might be a race condition regarding network acitivity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants