Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source HU Actions shall only be "Drop Source HU" #683

Closed
metas-mk opened this issue Nov 17, 2017 · 6 comments
Closed

Source HU Actions shall only be "Drop Source HU" #683

metas-mk opened this issue Nov 17, 2017 · 6 comments
Assignees
@teosarca
Labels
branch:master branch:release priority:high type:enhancement

Comments

@metas-mk
Copy link
Member

metas-mk commented Nov 17, 2017 •
edited
Loading

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, there are Source HU Actions available that are not useful for the user.

Which are the steps to reproduce?

Open and see.

What is the expected or desired behavior?

Reduce the actions of selected Source HU to only "Drop Source HU".

image
teosarca added a commit that referenced this issue Nov 21, 2017
@teosarca
avoid class cast exceptions when the view is not HUEditorView
2ffba39 
because those are poluting the console/log file

#683
teosarca added a commit that referenced this issue Nov 21, 2017
@teosarca
does show WEBUI_M_HU_Pick process for manufacturing source HUs rows
7eda6b2 
#683
teosarca added a commit that referenced this issue Nov 21, 2017
@teosarca
show HU Transform process only for HUEditorView(s)
6a505a5 
if the view is not HUEditorView will fail on execution anyways

#683
teosarca added a commit that referenced this issue Nov 21, 2017
@teosarca
hide WEBUI_PP_Order_ReverseCandidate for source HU rows
f2207f9 
#683
teosarca added a commit that referenced this issue Nov 21, 2017
@teosarca
hide WEBUI_M_HU_Pick process if there are no eligible HU rows
56a4635 
NOTE: we decided to hide this action when there is not available,
because we want to cover the requirements of
#683,
were we need to hide the action for source HU lines... and does not
worth the effort to handle particularly that case.

#683
@teosarca
Copy link
Member

NOTE: in case of Pick process, I've decided to hide this action when is not available, because we want to cover the requirements of #683, were we need to hide the action for source HU lines... and does not worth the effort to handle particularly that case.
Before this change, the action was shown but it was disabled.

@metas-dh
Copy link
Member

Results of IT1
tested in mf15

still have more Actions available for Source HU then "Drop Source HU":

production:
2017-11-22 11_31_05-metasfresh

picking:
2017-11-22 11_33_01-

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 26, 2017
@metas-ts
update ReleaseNotes.md
bfa6bcb 
[#1293](metasfresh/metasfresh-webui-frontend-legacy#1293)
Cannot scroll down in a filter with lots of parameters
[#669](metasfresh/metasfresh-webui-api-legacy#669)
CU-TU's built name and description is wrong
[#1366](metasfresh/metasfresh-webui-frontend-legacy#1366)
Error in Quickentry dropdown List
[#1345](metasfresh/metasfresh-webui-frontend-legacy#1345)
Invalid date was used on dateTime tablecell
[#701](metasfresh/metasfresh-webui-api-legacy#701)
webui server is losing session context
[#683](metasfresh/metasfresh-webui-api-legacy#683)
Source HU Actions shall only be "Drop Source HU"
[#1358](metasfresh/metasfresh-webui-frontend-legacy#1358)
View field editor: number field is behaving weird when using keyboard
[#2945](#2945) Adjustment
in pain001
[#3056](#3056) purchase
candidates: implement locking mechanism
[#694](metasfresh/metasfresh-webui-api-legacy#694)
purchase view: set modal title as process caption
[#700](metasfresh/metasfresh-webui-api-legacy#700)
Filter error after static filter set
[#3057](#3057) display
order, forecast or shipmentschedule in material dispo main window
[#3055](#3055) purchase
candidates: notify user when the purchase order was generated
[#697](metasfresh/metasfresh-webui-api-legacy#697)
New BPartner is not available as SubProducerBPartner in MaterialReceipt
BPartner
[#3034](#3034) solve
material dispo regressions
[#671](metasfresh/metasfresh-webui-api-legacy#671)
T_WEBUI_ViewSelection[Line] shall be truncated and not deleted
[#695](metasfresh/metasfresh-webui-api-legacy#695)
picking terminal: implement dynamic picking slot allocation/release
[#3043](#3043) A contract
shall not be created when a completing a quotation
[#1380](metasfresh/metasfresh-webui-frontend-legacy#1380)
Shortcut for new document
[#2944](#2944) Allow more
than 1 PostFinanceUserNo per Account
[#3023](#3023) ad_org is
ignored when doing quick order entry
[#1363](metasfresh/metasfresh-webui-frontend-legacy#1363)
jenkins: run npm test on each build
[#3010](#3010) Inherit
c_order_id and orderline_id from flatrate term to invoice candidate
[#2958](#2958) 2nd
Discount Break is ignored
[#2997](#2997) Partner
Import: Support importing the Org via value
[#689](metasfresh/metasfresh-webui-api-legacy#689)
Picking processed compress to top-level HU
[#692](metasfresh/metasfresh-webui-api-legacy#692)
Error in Quickentry Sales Order when canceling input
[#679](metasfresh/metasfresh-webui-api-legacy#679) HU
taken out in Picking Tray Clearing still displayed in the Picking Slot
in Picking Terminal
[#687](metasfresh/metasfresh-webui-api-legacy#687)
picking terminal: show BPartner instead of DeliveryDate
[#693](metasfresh/metasfresh-webui-api-legacy#693)
Error in create purchase orders from Sales order line
[#662](metasfresh/metasfresh-webui-api-legacy#662)
Aggregate Storage for Product and Warehouse
[#1351](metasfresh/metasfresh-webui-frontend-legacy#1351)
wrong backend api call for grid view editing

me-45
@teosarca
Copy link
Member

update: the picking is OK as it is. have to check the source HUs part...

@teosarca teosarca self-assigned this Dec 13, 2017
@teosarca
Copy link
Member

update: about manufacturing issue/receipt. I've took a look at those 3 processes:

  • Verarbeiten (de.metas.ui.web.pporder.process.WEBUI_PP_Order_ChangePlanningStatus_Complete)
  • Zur Prüfung freigeben (de.metas.ui.web.pporder.process.WEBUI_PP_Order_ChangePlanningStatus_Review)
  • Soll keine Quell-HU mehr sein (de.metas.ui.web.pporder.process.WEBUI_PP_Order_M_Source_HU_Delete)

The Verarbeiten and Zur Prüfung freigeben are shown whatever you select because those actions are about the manufacturing order and not about what u selected.

So, IMHO it's OK.

wdyt?

@metas-dh
Copy link
Member

The Verarbeiten and Zur Prüfung freigeben are shown whatever you select because those actions are about the manufacturing order and not about what u selected.
So, IMHO it's OK.

agree; @metas-mk wdyt?

@metas-dh
Copy link
Member

metas-dh commented Mar 1, 2018

checked w/ metas-mk: OK

@metas-dh metas-dh closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-mk @metas-dh