avoid class cast exceptions when the view is not HUEditorView

because those are poluting the console/log file #683
metasfresh · Nov 21, 2017 · 2ffba39 · 2ffba39
1 parent de93240
commit 2ffba39
Show file tree

Hide file tree

Showing 11 changed files with 62 additions and 1 deletion.
diff --git a/src/main/java/de/metas/ui/web/handlingunits/HUEditorProcessTemplate.java b/src/main/java/de/metas/ui/web/handlingunits/HUEditorProcessTemplate.java
@@ -42,6 +42,11 @@
  */
 public abstract class HUEditorProcessTemplate extends ViewBasedProcessTemplate
 {
+	protected final boolean isHUEditorView()
+	{
+		return isViewClass(HUEditorView.class);
+	}
+
 	@Override
 	protected final HUEditorView getView()
 	{
@@ -61,7 +66,7 @@ protected final Stream<HUEditorRow> streamSelectedRows(@NonNull final HUEditorRo
 		{
 			return Stream.empty();
 		}
-		
+
 		return getView().streamByIds(filter.andOnlyRowIds(selectedDocumentIds));
 	}
 

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveTUsToDirectWarehouse.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveTUsToDirectWarehouse.java
@@ -57,6 +57,11 @@ public class WEBUI_M_HU_MoveTUsToDirectWarehouse extends HUEditorProcessTemplate
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		final DocumentIdsSelection selectedRowIds = getSelectedDocumentIds();
 		if (!selectedRowIds.isSingleDocumentId())
 		{

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToAnotherWarehouse.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToAnotherWarehouse.java
@@ -57,6 +57,11 @@ public class WEBUI_M_HU_MoveToAnotherWarehouse extends HUEditorProcessTemplate i
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		if (!streamSelectedHUIds(Select.ONLY_TOPLEVEL).findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.reject(msgBL.getTranslatableMsgText(WEBUI_HU_Constants.MSG_WEBUI_ONLY_TOP_LEVEL_HU));

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToDirectWarehouse.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToDirectWarehouse.java
@@ -53,6 +53,11 @@ public class WEBUI_M_HU_MoveToDirectWarehouse extends HUEditorProcessTemplate im
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		final DocumentIdsSelection selectedRowIds = getSelectedDocumentIds();
 		if (selectedRowIds.isEmpty())
 		{

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToGarbage.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToGarbage.java
@@ -56,6 +56,11 @@ public class WEBUI_M_HU_MoveToGarbage extends HUEditorProcessTemplate implements
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		if (!streamSelectedHUIds(Select.ONLY_TOPLEVEL).findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.reject(msgBL.getTranslatableMsgText(WEBUI_HU_Constants.MSG_WEBUI_ONLY_TOP_LEVEL_HU));

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToQualityWarehouse.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_MoveToQualityWarehouse.java
@@ -59,6 +59,11 @@ public class WEBUI_M_HU_MoveToQualityWarehouse extends HUEditorProcessTemplate i
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		if (!streamSelectedHUIds(Select.ONLY_TOPLEVEL).findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.reject(msgBL.getTranslatableMsgText(WEBUI_HU_Constants.MSG_WEBUI_ONLY_TOP_LEVEL_HU));

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_PrintReceiptLabel.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_PrintReceiptLabel.java
@@ -48,6 +48,11 @@ public class WEBUI_M_HU_PrintReceiptLabel
 	@Override
 	public ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		final HUReportService huReportService = HUReportService.get();
 
 		final Properties ctx = Env.getCtx(); // note: at this point, the JavaProces's ctx was not set so we are using the global context

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnFromCustomer.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnFromCustomer.java
@@ -50,6 +50,11 @@ public class WEBUI_M_HU_ReturnFromCustomer extends HUEditorProcessTemplate imple
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		if (!streamSelectedHUIds(Select.ONLY_TOPLEVEL).findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.reject(msgBL.getTranslatableMsgText(WEBUI_HU_Constants.MSG_WEBUI_ONLY_TOP_LEVEL_HU));

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnTUsToVendor.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnTUsToVendor.java
@@ -71,6 +71,11 @@ public class WEBUI_M_HU_ReturnTUsToVendor extends HUEditorProcessTemplate implem
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		final DocumentIdsSelection selectedRowIds = getSelectedDocumentIds();
 		if (!selectedRowIds.isSingleDocumentId())
 		{

diff --git a/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnToVendor.java b/src/main/java/de/metas/ui/web/handlingunits/process/WEBUI_M_HU_ReturnToVendor.java
@@ -52,6 +52,11 @@ public class WEBUI_M_HU_ReturnToVendor extends HUEditorProcessTemplate implement
 	@Override
 	protected ProcessPreconditionsResolution checkPreconditionsApplicable()
 	{
+		if(!isHUEditorView())
+		{
+			return ProcessPreconditionsResolution.rejectWithInternalReason("not the HU view");
+		}
+
 		if (!streamSelectedHUIds(Select.ONLY_TOPLEVEL).findAny().isPresent())
 		{
 			return ProcessPreconditionsResolution.reject(msgBL.getTranslatableMsgText(WEBUI_HU_Constants.MSG_WEBUI_ONLY_TOP_LEVEL_HU));

diff --git a/src/main/java/de/metas/ui/web/process/adprocess/ViewBasedProcessTemplate.java b/src/main/java/de/metas/ui/web/process/adprocess/ViewBasedProcessTemplate.java
@@ -147,6 +147,17 @@ protected IView getView()
 		Check.assumeNotNull(_view, "View loaded");
 		return _view;
 	}
+
+	protected final <T extends IView> boolean isViewClass(@NonNull final Class<T> expectedViewClass)
+	{
+		final IView view = _view;
+		if(view == null)
+		{
+			return false;
+		}
+
+		return expectedViewClass.isAssignableFrom(view.getClass());
+	}
 
 	protected final void invalidateView(@NonNull final ViewId viewId)
 	{