Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T_WEBUI_ViewSelection[Line] shall be truncated and not deleted #671

Closed
teosarca opened this issue Nov 11, 2017 · 5 comments
Closed

T_WEBUI_ViewSelection[Line] shall be truncated and not deleted #671

teosarca opened this issue Nov 11, 2017 · 5 comments

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

bug

What is the current behavior?

on startup, those 2 tables are "DELETE FROM".

What is the expected or desired behavior?

we shall use TRUNCATE.

Shall be fixed in de.metas.ui.web.view.ViewsRepository.truncateTable(String)

@metas-ts
Copy link
Member

metas-ts commented Nov 13, 2017

Hi @teosarca @metasnw
truncating is is only a workaround..i guess it's OK since it's little effort now, but

  • we can't assume to have a downtime in which the truncate could be performed, so we are back at delete..we need to identify old records and remove them, on a regular base.
    • e.g. if the session of the user for which the selection was made ends
  • if we clean upon a regular basis, the table will stop growing at a certain point. It's true that disk space is not returned to the OS on the system, but given a proper vacuum setup (1. we need it anyways; 2. even with the default seup this holds true), the table's disk usage won't grow boundless, because disk space will be reused.

So if nothing else, i suggest to do a follow-up task to deal with this issue properly

@metasnw
Copy link
Member

metasnw commented Nov 23, 2017

@teosarca @metas-ts
yes, we can do a follow up but we need the truncate asap to have a 80% solution at all

@metas-ts
Copy link
Member

metas-ts commented Nov 23, 2017

hi @metasnw @teosarca ,
@metas-mk just talked with me about this.
A solution is not the truncate, but regular restarts.
Anyways you need those restarts right now.
the only difference wrt the disk usage is that with truncate, you get a sawtooth pattern and with delete, a "flat line" which is aproximately at the sawtooth's maximum

@metas-mk
Copy link
Member

@metas-ts decided for truncate in startup (as proposed in issue)

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 26, 2017
[#1293](metasfresh/metasfresh-webui-frontend-legacy#1293)
Cannot scroll down in a filter with lots of parameters
[#669](metasfresh/metasfresh-webui-api-legacy#669)
CU-TU's built name and description is wrong
[#1366](metasfresh/metasfresh-webui-frontend-legacy#1366)
Error in Quickentry dropdown List
[#1345](metasfresh/metasfresh-webui-frontend-legacy#1345)
Invalid date was used on dateTime tablecell
[#701](metasfresh/metasfresh-webui-api-legacy#701)
webui server is losing session context
[#683](metasfresh/metasfresh-webui-api-legacy#683)
Source HU Actions shall only be "Drop Source HU"
[#1358](metasfresh/metasfresh-webui-frontend-legacy#1358)
View field editor: number field is behaving weird when using keyboard
[#2945](#2945) Adjustment
in pain001
[#3056](#3056) purchase
candidates: implement locking mechanism
[#694](metasfresh/metasfresh-webui-api-legacy#694)
purchase view: set modal title as process caption
[#700](metasfresh/metasfresh-webui-api-legacy#700)
Filter error after static filter set
[#3057](#3057) display
order, forecast or shipmentschedule in material dispo main window
[#3055](#3055) purchase
candidates: notify user when the purchase order was generated
[#697](metasfresh/metasfresh-webui-api-legacy#697)
New BPartner is not available as SubProducerBPartner in MaterialReceipt
BPartner
[#3034](#3034) solve
material dispo regressions
[#671](metasfresh/metasfresh-webui-api-legacy#671)
T_WEBUI_ViewSelection[Line] shall be truncated and not deleted
[#695](metasfresh/metasfresh-webui-api-legacy#695)
picking terminal: implement dynamic picking slot allocation/release
[#3043](#3043) A contract
shall not be created when a completing a quotation
[#1380](metasfresh/metasfresh-webui-frontend-legacy#1380)
Shortcut for new document
[#2944](#2944) Allow more
than 1 PostFinanceUserNo per Account
[#3023](#3023) ad_org is
ignored when doing quick order entry
[#1363](metasfresh/metasfresh-webui-frontend-legacy#1363)
jenkins: run npm test on each build
[#3010](#3010) Inherit
c_order_id and orderline_id from flatrate term to invoice candidate
[#2958](#2958) 2nd
Discount Break is ignored
[#2997](#2997) Partner
Import: Support importing the Org via value
[#689](metasfresh/metasfresh-webui-api-legacy#689)
Picking processed compress to top-level HU
[#692](metasfresh/metasfresh-webui-api-legacy#692)
Error in Quickentry Sales Order when canceling input
[#679](metasfresh/metasfresh-webui-api-legacy#679) HU
taken out in Picking Tray Clearing still displayed in the Picking Slot
in Picking Terminal
[#687](metasfresh/metasfresh-webui-api-legacy#687)
picking terminal: show BPartner instead of DeliveryDate
[#693](metasfresh/metasfresh-webui-api-legacy#693)
Error in create purchase orders from Sales order line
[#662](metasfresh/metasfresh-webui-api-legacy#662)
Aggregate Storage for Product and Warehouse
[#1351](metasfresh/metasfresh-webui-frontend-legacy#1351)
wrong backend api call for grid view editing

me-45
@metas-dh metas-dh self-assigned this Dec 5, 2017
@metas-dh
Copy link
Member

checked with ts: does not need testing, created follow-up #737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants