Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incorrect AD_Window_ID in URL #603

Closed
metas-ts opened this issue Sep 20, 2017 · 1 comment
Closed

Handle incorrect AD_Window_ID in URL #603

metas-ts opened this issue Sep 20, 2017 · 1 comment

Comments

@metas-ts
Copy link
Member

Is this a bug or feature request?

FR

What is the current behavior?

If a user wants opens a window it is checked whether they have the respecitve rights.
If not, the attempt is logged and request is created that can later on be granted or declined.
Problem: if there is no such window (because a user mistyped an URL), then creating that request fails with a hard-to-understand exception.

The consequence is that instead of getting the message that the given window is not accessible, the user gets a very technical NoSuchForeignKeyException the conent of which is none of his business.

Which are the steps to reproduce?

just to to some window and change the number after the URLs /window/ part..e.g. append some zeros

What is the expected or desired behavior?

There shall be no NoSuchForeignKeyException, but the usual one that sais "you don't have access"

@metas-ts metas-ts self-assigned this Sep 20, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 20, 2017
* IRolePermLoggingBL: add NoSuchForeignKeyException
* MRolePermRequest: catch DBForeignKeyConstraintException and rethrow as
NoSuchForeignKeyException

Handle incorrect AD_Window_ID in URL
metasfresh/metasfresh-webui-api-legacy#603
metas-ts added a commit that referenced this issue Sep 20, 2017
metas-ts added a commit that referenced this issue Sep 20, 2017
Handle incorrect AD_Window_ID in URL #603
@metas-ts metas-ts removed their assignment Sep 21, 2017
metas-ts added a commit that referenced this issue Sep 21, 2017
Handle incorrect AD_Window_ID in URL #603
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Sep 24, 2017
[#608](metasfresh/metasfresh-webui-api-legacy#608) CU
Quantity in Excel Export from HU Editor is wrong
[#2477](#2477)
Subscription Import Window Adjustments
[#588](metasfresh/metasfresh-webui-api-legacy#588)
Cloning Feature: Error when cloning BOM
[#2541](#2541) Allow
filtering by product group in window product
[#2538](#2538) Remove
legacy LDAP code
[#576](metasfresh/metasfresh-webui-api-legacy#576)
Implement batch entry for Sales/Purchase Invoice documents
[#2484](#2484) allow
using partner product numbers and name for entering order line
[#2502](#2502) Allow
multiple shipment schedules per orderline
[#2395](#2395) Drop
C_Flatrate_Conditions.IsNewTermCreatesOrder together with java code
[#2529](#2529) Import
System users
[#607](metasfresh/metasfresh-webui-api-legacy#607)
AD_Column.IsMandatory shall be overwritten by MandatoryLogic
[#2514](#2514) Support
importing multiline fields
[#603](metasfresh/metasfresh-webui-api-legacy#603)
Handle incorrect AD_Window_ID in URL
[#1167](metasfresh/metasfresh-webui-frontend-legacy#1167)
Edit Fields in Main Grid View
[#2146](#2146) Implement
Generic Multi Tags / labels for records
[#2501](#2501) Import
Requests
[#2510](#2510) Prevent
users from creating duplicate main prices
[#2344](#2344) Support
version 02 CAMT54 file
[#1197](metasfresh/metasfresh-webui-frontend-legacy#1197)
frontend: export view to excel
[#2482](#2482) Allow
disabling of model interceptors on the fly
[#1194](metasfresh/metasfresh-webui-frontend-legacy#1194)
Use API to fetch the locale
[#591](metasfresh/metasfresh-webui-api-legacy#591)
Filter by warehouse when selecting HUs to issue
[#593](metasfresh/metasfresh-webui-api-legacy#593)
Remove Clone action if not supported
[#2492](#2492) Process
C_Dunning_Candidate_Process fails
[#491](metasfresh/metasfresh-webui-api-legacy#491)
Wrong widget Type for Date-Range in Process Parameter

me-45
@metas-lc
Copy link

IT
opened a window that doesn't exists => Error: NoAccess...
Server error
NoAccess
OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants