Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Process panel - mandatory flag is not respected #141

Closed
teosarca opened this issue Dec 7, 2016 · 11 comments
Closed

Process panel - mandatory flag is not respected #141

teosarca opened this issue Dec 7, 2016 · 11 comments

Comments

@teosarca
Copy link
Member

teosarca commented Dec 7, 2016

Test case:

  • try running a process which have mandatory parameters

NOTE:

  • mandatory parameters are NOT marked in a way, so user have no idea what's mandatory and what not
  • mandatory parameters are not validated so basically when user presses "Start" it relies on backend to throw an exception because one of the mandatory params were not set

e.g.
image

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Dec 9, 2016

Mandatory fields are marked in a way. How do you want to marked them? We assumed that mandatory fields have blue outline.

@teosarca
Copy link
Member Author

teosarca commented Dec 9, 2016

ahhh, forgot... but on the other hand seems that it wan't intuitive for me :))

Ok, we have just to solve the second part. How shall we deal with mandatory fields.
Atm, frontend it's just asking the backend the start the process and the backend throws an exception.
But from UX it would be nice if the user would notified in a nicer way...
wdyt?

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Dec 9, 2016

  1. I can just avoid to sending call if all mandatory fields are not filled (that's how we handle now most of mandatory fields) - but there won't be notification.
  2. Displaying notifications with errors is one possible way for now to display errors in forms/widgets because we never talked about handling errors by widgets.

@teosarca
Copy link
Member Author

teosarca commented Dec 9, 2016

@damianprzygodzki you are right. I think we shall improve the backend as described here: metasfresh/metasfresh-webui-api-legacy#88

wdyt?

@teosarca
Copy link
Member Author

UPDATE: for any field we are providing now 2 more properties:

  • valid : true | false
  • validReason: "string" // reason why field is not valid

@damianprzygodzki
Copy link
Contributor

#253 Check this related issue, and i think we should apply it for every widget (i am describing this particular case). Before implementation, we need assumption here, or there.

@cadavre
Copy link
Contributor

cadavre commented Apr 19, 2017

@teosarca can you please verify if this issue is still up-to-date?

@teosarca
Copy link
Member Author

quick checked, the "validStatus" is still not considered.

@teosarca
Copy link
Member Author

not sure if the backend shall provide something more....

@cadavre
Copy link
Contributor

cadavre commented Apr 19, 2017

AFAIK "when user presses "Start" it relies on backend to throw an exception" is what we all agreed on as front-end is not made for data validation – backend is responsible for it. In this perspective this issue is not valid.

@teosarca
Copy link
Member Author

yup, ofc, the backend is validating it. let's close it for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants