Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

ShipmentSchedule: Only displayed after "No data" showing up #433

Closed
metas-dh opened this issue Feb 24, 2017 · 5 comments
Closed

ShipmentSchedule: Only displayed after "No data" showing up #433

metas-dh opened this issue Feb 24, 2017 · 5 comments
Assignees
@damianprzygodzki @metas-dh
Labels
branch:master branch:release type:bug

Comments

@metas-dh
Copy link
Member

metas-dh commented Feb 24, 2017 •
edited
Loading

Type of issue

Bug

Current behavior

"No data" page is shown for a split second, then the actual data is displayed

Expected behavior

"No data" should only be displayed if there actually is no data; if data exists, show that directly.

Steps to reproduce

  • Go to Sales Order window. Create a new Sales Order. Complete the Sales Order.
  • Open Action menu. Referenced documents, open Lieferdisposition/ Shipment Schedule.
    => The window shows the "No data" page for a split second, then the shipment schedules are displayed
@teosarca
Copy link
Member

Suggestion: imho,

  • when opening the grid view, instead of no data we shall display nothing or some "Loading..." text
  • when the rows were fetched from the endpoint, we shall display the rows or the "no data" message.

@metas-dh metas-dh added this to the 2017-09 milestone Feb 24, 2017
@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Feb 27, 2017 •
edited
Loading

@cadavre @teosarca what should we do here? Shouldn't we start with #130? Or just quick-fix it?

@cadavre
Copy link
Contributor

cadavre commented Feb 27, 2017

This is a part of #130 . Postponing since #130 is resolved.

@teosarca
Copy link
Member

@cadavre i don't think it's part of #130. Just DON'T show the "no data" label if nobody tried to load the data yet.
Actually it's pretty similar with #425 (comment) .

@metas-mk metas-mk modified the milestones: 2017-12, 2017-09 Mar 6, 2017
@cadavre cadavre modified the milestones: 2017-13, 2017-12 Mar 21, 2017
@damianprzygodzki damianprzygodzki removed this from the 2017-13 milestone Mar 21, 2017
@damianprzygodzki damianprzygodzki self-assigned this Mar 24, 2017
damianprzygodzki added a commit that referenced this issue Mar 28, 2017
@damianprzygodzki
#433 Preventing the empty error displaying on pending init
ac1aabe
damianprzygodzki added a commit that referenced this issue Mar 28, 2017
@damianprzygodzki
#433 Preventing the empty error displaying on pending init (fix)
ff4873d
@metas-dh metas-dh self-assigned this Mar 29, 2017
@metas-dh
Copy link
Member Author

Results of IT1
tested on w101

  • tested with newly created sales order and already existing sales orders, opening shipment schedules from Actions button: "No data" is not shown anymore, the shipment schedules are displayed right away

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2017
@metas-ts
adding additional items to the RNs
015fe73 
[#1382](#1382) Make Packing Item editable in Manufacturing Order Header
[#323](metasfresh/metasfresh-webui-api-legacy#323) Manufacturing Issue/Receipt: receipt lines shall be displayed first
[#689](metasfresh/metasfresh-webui-frontend-legacy#689) Image widget is missing right border
[#326](metasfresh/metasfresh-webui-api-legacy#326) technical: Remove JSONProcessInstanceResult deprecated properties
[#680](metasfresh/metasfresh-webui-frontend-legacy#680) Navigation breadcrumb vs. Navigation Menu
[#329](metasfresh/metasfresh-webui-api-legacy#329) Issue HU 404 not found#
[#688](metasfresh/metasfresh-webui-frontend-legacy#688) Main page /dashboard is broken
[#667](metasfresh/metasfresh-webui-frontend-legacy#667) Change /rest/api/pattribute request message
[#319](metasfresh/metasfresh-webui-api-legacy#319) Manufacturing Issue/Receipt: show BOM line attributes if any
[#317](metasfresh/metasfresh-webui-api-legacy#317) Manufacturing Issue/Receipt: drop StatusInfo column
[#248](metasfresh/metasfresh-webui-frontend-legacy#248) Handle Password Fields in WebUI
[#678](metasfresh/metasfresh-webui-frontend-legacy#678) Get rid of deprecated static docNo input in header.
[#151](metasfresh/metasfresh-webui-api-legacy#151) grid view websocket notifications: fullyChanged shall not be set when changedIds is set
[#664](metasfresh/metasfresh-webui-frontend-legacy#664) process doesn't open directly
[#311](metasfresh/metasfresh-webui-api-legacy#311) Switching language does not translate document lookup values
[#310](metasfresh/metasfresh-webui-api-legacy#310) Switching language does not translate document references
[#306](metasfresh/metasfresh-webui-api-legacy#306) Address missing in 'Adresse' for bpartner created on-the-fly
[#673](metasfresh/metasfresh-webui-frontend-legacy#673) Wrong report file endpoint is called for processes which are started from main menu
[#1347](#1347) technical: ModelClassGenerator shall generate BigDecimal.ZERO instead of Env.ZERO
[#880](#880) Improve IProcessPrecondition framework
[#641](metasfresh/metasfresh-webui-frontend-legacy#641) Shortcuts behavior sometimes weird
[#644](metasfresh/metasfresh-webui-frontend-legacy#644) Creating a new Discount record error
[#649](metasfresh/metasfresh-webui-frontend-legacy#649) windowId shall be handled as a string and not as a number
[#596](metasfresh/metasfresh-webui-frontend-legacy#596) red line appears on document only after refresh
[#433](metasfresh/metasfresh-webui-frontend-legacy#433) ShipmentSchedule: Only displayed after "No data" showing up
[#270](metasfresh/metasfresh-webui-api-legacy#270) cannot add trading unit with batch entry after using add new
[#537](metasfresh/metasfresh-webui-frontend-legacy#537) KPI: implement a non intrusive way to display KPI related errors
[#268](metasfresh/metasfresh-webui-api-legacy#268) HU attributes shall always provide the WidgetType along with the data/changes
[#579](metasfresh/metasfresh-webui-frontend-legacy#579) DocumentNo field is not updated

me-45
hairy tinkerbell struck again
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-dh metas-dh

Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-mk @metas-dh