Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

windowId shall be handled as a string and not as a number #649

Closed
teosarca opened this issue Apr 19, 2017 · 1 comment
Closed

windowId shall be handled as a string and not as a number #649

teosarca opened this issue Apr 19, 2017 · 1 comment
Assignees
@damianprzygodzki @metas-lc @Dunkat
Labels
branch:master branch:release type:enhancement
Milestone
2017-17

Comments

@teosarca
Copy link
Member

Current behavior

It seems the frontend code is handling the windowId as a number.

Expected behavior

The windowId shall be handled as a string and it shall never be parsed to integer.

Steps to reproduce

NOTE: it cannot be reproduced on current master, i found this issue while developing/experimenting some new approach.

Steps to reproduce were:

  • open receipt candidates
  • try to receive some HUs, NOTE that the "HU editor"'s windowId is "huEditor".

Bellow are the screenshots:
image
@teosarca teosarca added this to the 2017-17 milestone Apr 19, 2017
Dunkat added a commit that referenced this issue Apr 19, 2017
@Dunkat
windowId shall be handled as a string and not as a number #649
31f1347
damianprzygodzki added a commit that referenced this issue Apr 19, 2017
@damianprzygodzki
Merge pull request #652 from metasfresh/dev-649
266d158 
windowId shall be handled as a string and not as a number #649
@metas-lc metas-lc self-assigned this Apr 20, 2017
@metas-lc
Copy link

IT
since we don't have any windowID that is string i just opened a window "aaa" to check how the layout on preview looks like: "...documentView/aaa.." (as you can see in the picture above, before it was NaN) OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2017
@metas-ts
adding additional items to the RNs
015fe73 
[#1382](#1382) Make Packing Item editable in Manufacturing Order Header
[#323](metasfresh/metasfresh-webui-api-legacy#323) Manufacturing Issue/Receipt: receipt lines shall be displayed first
[#689](metasfresh/metasfresh-webui-frontend-legacy#689) Image widget is missing right border
[#326](metasfresh/metasfresh-webui-api-legacy#326) technical: Remove JSONProcessInstanceResult deprecated properties
[#680](metasfresh/metasfresh-webui-frontend-legacy#680) Navigation breadcrumb vs. Navigation Menu
[#329](metasfresh/metasfresh-webui-api-legacy#329) Issue HU 404 not found#
[#688](metasfresh/metasfresh-webui-frontend-legacy#688) Main page /dashboard is broken
[#667](metasfresh/metasfresh-webui-frontend-legacy#667) Change /rest/api/pattribute request message
[#319](metasfresh/metasfresh-webui-api-legacy#319) Manufacturing Issue/Receipt: show BOM line attributes if any
[#317](metasfresh/metasfresh-webui-api-legacy#317) Manufacturing Issue/Receipt: drop StatusInfo column
[#248](metasfresh/metasfresh-webui-frontend-legacy#248) Handle Password Fields in WebUI
[#678](metasfresh/metasfresh-webui-frontend-legacy#678) Get rid of deprecated static docNo input in header.
[#151](metasfresh/metasfresh-webui-api-legacy#151) grid view websocket notifications: fullyChanged shall not be set when changedIds is set
[#664](metasfresh/metasfresh-webui-frontend-legacy#664) process doesn't open directly
[#311](metasfresh/metasfresh-webui-api-legacy#311) Switching language does not translate document lookup values
[#310](metasfresh/metasfresh-webui-api-legacy#310) Switching language does not translate document references
[#306](metasfresh/metasfresh-webui-api-legacy#306) Address missing in 'Adresse' for bpartner created on-the-fly
[#673](metasfresh/metasfresh-webui-frontend-legacy#673) Wrong report file endpoint is called for processes which are started from main menu
[#1347](#1347) technical: ModelClassGenerator shall generate BigDecimal.ZERO instead of Env.ZERO
[#880](#880) Improve IProcessPrecondition framework
[#641](metasfresh/metasfresh-webui-frontend-legacy#641) Shortcuts behavior sometimes weird
[#644](metasfresh/metasfresh-webui-frontend-legacy#644) Creating a new Discount record error
[#649](metasfresh/metasfresh-webui-frontend-legacy#649) windowId shall be handled as a string and not as a number
[#596](metasfresh/metasfresh-webui-frontend-legacy#596) red line appears on document only after refresh
[#433](metasfresh/metasfresh-webui-frontend-legacy#433) ShipmentSchedule: Only displayed after "No data" showing up
[#270](metasfresh/metasfresh-webui-api-legacy#270) cannot add trading unit with batch entry after using add new
[#537](metasfresh/metasfresh-webui-frontend-legacy#537) KPI: implement a non intrusive way to display KPI related errors
[#268](metasfresh/metasfresh-webui-api-legacy#268) HU attributes shall always provide the WidgetType along with the data/changes
[#579](metasfresh/metasfresh-webui-frontend-legacy#579) DocumentNo field is not updated

me-45
hairy tinkerbell struck again
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@damianprzygodzki damianprzygodzki

@metas-lc metas-lc

@Dunkat Dunkat

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
2017-17
Development

No branches or pull requests
6 participants
@cadavre @teosarca @metas-ts @damianprzygodzki @metas-lc @Dunkat