Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

If New document fails the window remains white #501

Closed
teosarca opened this issue Mar 6, 2017 · 5 comments
Closed

If New document fails the window remains white #501

teosarca opened this issue Mar 6, 2017 · 5 comments
Assignees

Comments

@teosarca
Copy link
Member

teosarca commented Mar 6, 2017

Type of issue

Bug / Feature request

Current behavior

Open receipt new candidate.
The endpoint fails because it's not allowed.
But the page was already switched and the new page failed to load.

Expected behavior

Stay it the window while the "/window/new" endpoint is executed and switch only if the it succeeded.

image

@teosarca teosarca added this to the 2017-11 milestone Mar 6, 2017
@cadavre cadavre modified the milestones: 2017-13, 2017-11 Mar 21, 2017
@damianprzygodzki
Copy link
Contributor

#253 Part of disscusion here about 404 generic error page.

@teosarca
Copy link
Member Author

@damianprzygodzki hmmm, ok, but how a 404 page would solve this case?

@cadavre
Copy link
Contributor

cadavre commented Mar 27, 2017

Hmm, I believe this is the place for 404. ;) It is a bad behaviour to change user's URL without his action. If he click something – URL changes, what you want to do is change it back (history-1) and display error. We want to show 404 because it's default behaviour of web. Think about it also in cases where we don't have "previous pages" – like when entering page from copied URL.

@teosarca
Copy link
Member Author

shall be solved as discussed on #651

@damianprzygodzki
Copy link
Contributor

Closing it due to integration of #651

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants