string fields are not marked as mandatory when empty

[metas-lc]

Type of issue

Bug

Current behavior

string fields (e.g. Name) are not marked as mandatory when you remove them

Expected behavior

field should get red and marked as mandatory

Steps to reproduce

1. go to Product window
2. take an already existing product and remove the name
   => product is saved, even if the name is mandatory.
   => no red mark to see that the name is not set
   => name is empty not null, probably that's why

Window: 140

Entity: e.g. 1000001

[teosarca]

hmmm, i think this one can and shall be completely solved on backend: metasfresh/metasfresh#1173

[teosarca]

update: we workaround this issue on backend side,
but i think that we shall also implement this logic on frontend.

i.e. for text fields, null and empty shall be considered as "field is not field"... so in case it's mandatory, it will be painted accordingly.
@damianprzygodzki can we implement this easily on frontend, without turning the world upside down and without workarounds ?

[damianprzygodzki]

We are marking mandatory field in that way (and it is okay, because it relays fully on frontend) but in my opinion we should do not force input-error state on frontend site. I can copy the same condition that is triggering input-mandatory state, but i fear that forcing something on frontend, that relays on API in future can corrupt API state. I.e. if you set on API that the input is valid (just because) and some condition will be blocking API state - and without going into code, you cant check why.

[cadavre]

True validation shall be made on backend because it's the place to save correct data. Front-end is responsible for displaying validation results, not validation itself. We should stick to one place with validation and not spread it because it will end up not being debuggable.

[teosarca]

Thanks guys for checking it.
Seems ok now so i am closing this issue.