Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

View field editor: override viewEditorRenderMode on row level #1360

Closed
teosarca opened this issue Nov 20, 2017 · 10 comments
Closed

View field editor: override viewEditorRenderMode on row level #1360

teosarca opened this issue Nov 20, 2017 · 10 comments

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

FR
follow-up of #1335

What is the current behavior?

The viewEditorRenderMode it's specified in view layout, per column and frontend considers it.
But now, in some cases, the backend is providing viewEditorRenderMode per view row-field.

Which are the steps to reproduce?

What is the expected or desired behavior?

When the viewEditorRenderMode property is specified per row-field, it shall override the value specified in layout.

@wiadev
Copy link
Contributor

wiadev commented Nov 24, 2017

@teosarca @metas-lc can you provide me the example which has multi includedDocuments? I wanna go through several use cases.

@teosarca
Copy link
Member Author

@wiadev just configured 2 more vendors to that Salat product:

image

teosarca added a commit that referenced this issue Nov 27, 2017
fix: override viewEditorRenderMode on row level #1360
@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  1. open e.g. window 123, select tab location
  2. click Add new: modal does not open, but you get question if you want to leave the page:

2017-11-27 16_15_34-metasfresh

  1. Click cancel twice, so the small window disappears: window is completely empty:

2017-11-27 16_20_38-metasfresh

  1. Refresh the window: a new entry was created for location, but it's empty and the line is red:

2017-11-27 16_16_20-metasfresh

@wiadev
Copy link
Contributor

wiadev commented Nov 28, 2017

@metas-dh I'm testing on w101 and I don't have Add new button.

screenshot at nov 28 14-05-44

@metas-dh
Copy link
Member

@wiadev sorry, i thought it was called "Add new" in the english version; it's "Neu hinzufügen"

i mean this one:

2017-11-28 15_11_53-metasfresh

(btw, there is no button in the first tab in bpartner window bc you create new entries only with Action menu - Create Request, afaik)

@wiadev
Copy link
Contributor

wiadev commented Nov 28, 2017

@metas-dh
I've fixed the issue of not showing Add New modal and played around a little.

but when I've put the name on Add New modal and hit Done, nothing was added in the table. am I missing something?

screenshot at nov 28 16-37-59

wiadev added a commit that referenced this issue Nov 28, 2017
@metas-dh
Copy link
Member

@wiadev
the country field in address is mandatory, so without setting that no new entry will be created (sorry for not mentioning that earlier).
so, you have to

  1. click Edit for Address
  2. Set the country
  3. When that's saved, click Done => new entry shall be created

2017-11-28 17_08_20-metasfresh

@wiadev
Copy link
Contributor

wiadev commented Nov 28, 2017

@metas-dh Thanks for clarification.
I've followed your steps and it works. you can start testing after @teosarca merge #1388 .

teosarca added a commit that referenced this issue Nov 28, 2017
@metas-dh
Copy link
Member

@wiadev thanks for the info

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Dec 1, 2017
[#2177](#2177) New Window
for Attribute Search in WebUI
[#3117](#3117) Disable
MStorage.add
[#1357](metasfresh/metasfresh-webui-frontend-legacy#1357)
Don't use the legacy view attributes API
[#1367](metasfresh/metasfresh-webui-frontend-legacy#1367)
view attributes shall be refreshed when the current selected row is
refreshed
[#3041](#3041) Forecast
Window copy Field content from header to lines when creation
[#3040](#3040) Implement
Clone/ Copy for Forecast Window WebUI
[#1360](metasfresh/metasfresh-webui-frontend-legacy#1360)
View field editor: override viewEditorRenderMode on row level
[#2868](#2868) Make
BOMValidate process to work correctly in webui
[#2956](#2956) drop
allowconsolidateinvoice from database
[#3073](#3073) Error:
Could not find or load main class ${argLine}
[#3072](#3072)
de_metas_purchasecandidate schema containing some diagnosis views
[#705](metasfresh/metasfresh-webui-api-legacy#705)
Backend Logic for new Date Filter Widget
[#3064](#3064) Multiple
PP Order generation for a materialdispo line
[#3088](#3088) Transform
in material receipt left destroyed HU behind
[#3086](#3086) HU planned
after Purchase Order, destroyed after material receipt
[#3089](#3089) Not able
to start report service with ReportServiceMain.launch
[#3042](#3042)
C_Bpartner: new Additional fields
[#3060](#3060)
TypedSqlQuery Bugs because aggregateList method ignores order
[#3054](#3054) purchase
candidates: document references

me-45
@metas-dh
Copy link
Member

metas-dh commented Dec 5, 2017

Results of IT2
tested in mf15

  • View field editor: override viewEditorRenderMode on row level: OK (QtyToPurchase and DatePromised are editable only in included rows
  • problem with new entry for included tab fixed as well

@metas-dh metas-dh closed this as completed Dec 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants