Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098

Closed
teosarca opened this issue Nov 28, 2017 · 2 comments
Closed

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098

teosarca opened this issue Nov 28, 2017 · 2 comments
Assignees
@metas-ts
Labels
priority:high type:enhancement

Comments

@teosarca
Copy link
Member

teosarca commented Nov 28, 2017 •
edited
Loading

Is this a bug or feature request?

FR
follow-up of #3079, #3078

What is the current behavior?

there is no way to fetch the available stock for a given bpartner.

What is the expected or desired behavior?

  • MaterialQuery shall support bpartnerId when fetching available stock
  • de.metas.material.dispo.commons.repository.AvailableStockResult.ResultGroup shall contain and return: warehouseId, bpartnerId
teosarca added a commit that referenced this issue Nov 28, 2017
@teosarca
introduce MaterialQuery.bpartnerId - just prototype; not working
b0145ca 
#3098
#3079
teosarca added a commit that referenced this issue Nov 28, 2017
@teosarca
AvailableStockResult.ResultGroup: warehouseId, bpartnerId (prototype)
0b7e001 
#3098
#3079
teosarca added a commit that referenced this issue Nov 30, 2017
@teosarca
fixes & impl see below
e12bc86 
#3079
* fixes
* refactoring

#3098
* added placeholders for querying by BPartner

#3104
* introduced MaterialMultiQuery.addToPredefinedBuckets(boolean) flag
@teosarca
Copy link
Member Author

teosarca commented Nov 30, 2017 •
edited by metas-ts
Loading

update: all that needs to be done here is:

  • MD_Candidate_Stock_v shall support C_BPartner_ID column
  • de.metas.material.dispo.commons.repository.StockRepositorySqlHelper.createDBQueryForMaterialQuery(MaterialQuery) - un-comment the code which is filtering by C_BPartner_ID
  • de.metas.material.dispo.commons.repository.StockRepository.createResultGroupAddRequest(I_MD_Candidate_Stock_v) - set ResultGroupAddRequest's bpartnerId from stockRecord

All work is in gh3079 branch

metas-ts added a commit that referenced this issue Nov 30, 2017
@metas-ts
WIP: make intermediate changes needed by @teosarcy to move on.
7f4d2e7 
See #3098 (comment)
TODO: add bpartner-ID to events etc etc
material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Nov 30, 2017
@metas-ts
WIP: Add SQL for the new C_BPartner-columns
a7b3d6a 
See #3098 (comment)
TODO: add bpartner-ID to events etc etc
material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
WIP - refactoring
763acd1 
* use MaterialDescriptorQuery instead of MaterialDescriptor within CandidatesQuery
  * TODO remove the "completeness"-Y/N stuff from MaterialDescriptor because it not *always* has to be complete
* rename MaterialQuery to StockQuery (MaterialMultiQuery to StockMultiQuery)
* rename AvailableStockResult to StockResult, so everything "stock" now starts with "stock" in that package

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
WIP - remove all the code that kept track of whether a MaterialDescri…
0a75636 
…ptor is complete or not

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
solve that compile error on jenkins; add bPartnerId to query class
a4da464 
material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
Refactor&Rename&add bpartner-ID
c27417d 
material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
add bpartner-ID also when advising to create PPOrders and DDOrders
3084384 
material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 1, 2017
@metas-ts
adapts stuff to get avaialablestock for a given bpartner
b13764f 
...this needs to include stock not tagged to any bpartner.
also:
* renamed different stuff for more consistency
* POJOQuery fix bug wrt addUnion in case the "first" query returns no result
* IQuery improve javadoc a bit

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 4, 2017
@metas-ts
solve performance problems getting the available stock
8b3abf2 
* solve spelling error in index-DDL (which rendered the index useless)
* solve perf problems wrt getting latest date

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
metas-ts added a commit that referenced this issue Dec 4, 2017
@metas-ts
solve performance problems getting the available stock
e4cd1f0 
* solve spelling error in index-DDL (which rendered the index useless)
* solve perf problems wrt getting latest date

material-dispo: MaterialQuery shall support bpartnerId when fetching available stock #3098
(cherry picked from commit 8b3abf2)
@metas-dh
Copy link
Member

All testing is done in #3079, moving this to Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-ts metas-ts

Labels
priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-dh