Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception handling: make them more translatable #4071

Closed
teosarca opened this issue May 18, 2018 · 1 comment
Closed

exception handling: make them more translatable #4071

teosarca opened this issue May 18, 2018 · 1 comment
Assignees
@teosarca @metas-lc
Labels
branch:release bug_please_use_type:bug_instead type:enhancement

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

FR
triggered by #4063

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

use ITranslatableString as exception messages.

Note to IT

nothing to test. e2e is sufficient. Pay attention to exception/error messages. They shall be like before, if not sexier.
@teosarca teosarca self-assigned this May 18, 2018
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
BPartnerBL.getBPartnerValueAndName: more robust; don't fail
b95d4c2 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
MailBL: improve error message
8fad252 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
IPriceListDAO: getPricingSystemName, getPriceListName
e16ce7e 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
IProductBL.getProductValueAndName
907fcba 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
ICOuntryDAO.getCountryNameById
43c1ec4 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
improve IMsgBL and ITranslatableString support
852902f 
#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
refactored AdempiereException and switched completelly to ITranslatab…
9c68ebd 
…leString

#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
minor
0e30d06 
#4071
teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue May 18, 2018
@teosarca
refactor
faa764c 
metasfresh/metasfresh#4071
teosarca added a commit that referenced this issue May 18, 2018
@teosarca
AdempiereException.ofADMessage
334c49f 
#4071
metas-ts added a commit that referenced this issue May 22, 2018
@metas-ts
update ReleaseNotes.md
7ae088f 
[#4073](#4073) Virtual Tabs implementation
[#4018](#4018) QtyCU not respected in Quarantine DD_Orderline
[#4063](#4063) Enhanced Pricing: Discount Break is falsely invalidated
[#4032](#4032) Show Pricing Conditions of Business Partner
[#4001](#4001) Calculate Purchase price with yearly Bonus
[#3999](#3999) New contract Type: Yearly Bonus from vendors
[#4070](#4070) WebUI Windows for new contract Type "Yearly
[#1789](metasfresh/metasfresh-webui-frontend-legacy#1789) user notifications: handle view target type
[#4071](#4071) exception handling: make them more translatable
[#4047](#4047) CleverReach get paginated receivers list
[#18](metasfresh/metasfresh-dist-legacy#18) create docker image automatically via jenkins
[#93](metasfresh/metasfresh-dist-orgs#92) Postal Lookup for Switzerland CH
[#4052](#4052) NPE when deleting inoutline with empty product
[#4062](#4062) Pricing conditions modal: allow changing pricing type, edit pricing system etc
[#4056](#4056) webui: pimp Partner Pharma - Purchase schedule tab
[#4030](#4030) create webui windows for marketing and cleverreach settings
[#1790](metasfresh/metasfresh-webui-frontend-legacy#1790) view: refresh after removing a static filter
[#3879](#3879) Add link and templates for email notification
[#4002](#4002) Purchase Order Aggregation
[#3792](#3729) Setting a different invoice bpartner causes error
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
minor
73085c1 
#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
minor
d360881 
#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
AdempiereException.getMessage - always return localized message
3b67cad 
#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
AdempiereException(ITransaltableString, cause)
22572e3 
#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
MsgBL.parseTranslatableString shall use "translatable"
3ef541e 
instead of getTranslatableMsgText

#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
DocumentProcessingException: improve text message builder
c1147b2 
#4071
teosarca added a commit that referenced this issue May 22, 2018
@teosarca
C_Order: improve error messages
47c4db8 
#4071
teosarca added a commit that referenced this issue May 25, 2018
@teosarca
DBForeignKeyConstraintException: improve error message
3341c31 
i.e. include cause's message

#4071
teosarca added a commit that referenced this issue Jun 9, 2018
@teosarca
DBException: preserve cause's error message
ae9b075 
#4071
@metas-lc metas-lc self-assigned this Jun 11, 2018
@metas-lc
Copy link
Contributor

e2e was fine OK
checked an error message when you try to order more than the credit limit => message was fine OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

@metas-lc metas-lc

Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-lc