Shipmentschedule not updated after order reactivate and re-complete #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* close and open affected shipment schedules as the respective sales order is reactivated and completed again #5960
* when opening a shipment schedule, then also update with stuff from the respective referenced object * cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments #5960
* prevent reactivation if shipment schedule is already processed #5960
* also create or extend shipment schedule's ASI (#4870) * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched * generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again #5960
|
Complexity increasing per file
==============================
- de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/api/impl/ReceiptScheduleASIAware.java 2
- de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/modelvalidator/C_Order_ShipmentSchedule.java 1
- de.metas.business/src/main/java/org/adempiere/mm/attributes/api/impl/AttributeSetInstanceBL.java 4
Complexity decreasing per file
==============================
+ de.metas.swat/de.metas.swat.base/src/main/java/de/metas/order/inoutcandidate/OrderLineShipmentScheduleHandler.java -2
+ de.metas.swat/de.metas.swat.base/src/main/java/de/metas/inoutcandidate/api/impl/ShipmentScheduleUpdater.java -2
See the complete overview on Codacy |
metas-ts
commented
Dec 21, 2019
metas-ts
added a commit
that referenced
this pull request
Dec 21, 2019
(the failing tests were addressed) * Shipmentschedule not updated after order reactivate and re-complete * close and open affected shipment schedules as the respective sales order is reactivated and completed again #5960 * Shipmentschedule not updated after order reactivate and re-complete * when opening a shipment schedule, then also update with stuff from the respective referenced object * cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments #5960 * Shipmentschedule not updated after order reactivate and re-complete * prevent reactivation if shipment schedule is already processed #5960 * fix unit test #5960 * Shipmentschedule not updated after order reactivate and re-complete * also create or extend shipment schedule's ASI (#4870) * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched * generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again #5960 (cherry picked from commit 3541ee9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5960