Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly refresh viewId for included view #7035

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Properly refresh viewId for included view #7035

merged 1 commit into from
Jul 20, 2020

Conversation

siemiatj
Copy link
Contributor

@siemiatj siemiatj commented Jul 20, 2020 •
edited
Loading

I still have to figure out a way to test it but other than that - good to go.

@siemiatj
Copy link
Contributor Author

There's something weird happening on the backend: https://recordit.co/7EGGKnfpvi . Sometimes it sends the same includedView for other rows even though it shouldn't. Sometimes it even does that after I unpick HU. But it's completely random.

@siemiatj siemiatj requested a review from petrican July 20, 2020 13:32
petrican
petrican approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@petrican petrican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but I would like to run first the e2e suite of tests before merging

@petrican
Copy link
Contributor

petrican commented Jul 20, 2020 •
edited
Loading

Tried to deploy a dev instance with it but it failed for some reason I do
not know https://chat.metasfresh.org/metasfresh/pl/tjbgm8htj3badyje8n79wb48ia. Will check in the morning. Thanks @siemiatj

@siemiatj siemiatj merged commit a7f8ae3 into master Jul 20, 2020
@siemiatj siemiatj deleted the frontend-fix-hu branch July 20, 2020 23:08
dragospodariu96 added a commit that referenced this pull request Jul 23, 2020
@dragospodariu96 @metas-ts
@TheBestPessimist @metas-Kay @teosarca @petrican @KommunikativCh @siemiatj
Gh7012 receipt schedule adj (#7047)
75cac97 
* extending the json-pojos; about to add tables and stuff

* implement big part of shipment schedule exporting

TODO
* unit tests for ShipmentCandidateExporter and ShipmentScheduleAuditRepository
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinante what's missing

#7012

* add "Export" fields to shipment schedule window

TODO
* unit tests for ShipmentCandidateExporter and ShipmentScheduleAuditRepository
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinante what's missing

#7012

* work on ShipmentCandidateExporterTest

TODO
* unit tests for ShipmentCandidateExporter
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* #7012 New Shipment Disposition Window.

* #7012 Removed script belonging to private repo.

* finish ShipmentCandidateExporterTest and add another export status

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* create filemaker-pojos so we can read&write XML

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* minor fixes

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* minor fixes

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* add additional exportstatus "don't export"

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* add additional exportstatus "don't export"

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* go at another enforcer dependency convergence error

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* `Picking Terminal V2`: Add process for picking and packing in 1 step (#6950)

(cherry picked from commit c03f7d2)

* ProductsToPickViewFactory: Inject the constructor via Spring instead of SpringContextHolder (#6970)

#6949
(cherry picked from commit 9d6fda6)

* Picking Terminal V2: Pick&Pack: Skip rows with qty 0 (#7022)

(cherry picked from commit fd95e03)

* Fixes after cherrypicks

#7021

* work on camel testing

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* Updated ReleaseNotes.md

added issues

* minor fix: don't export scheds with qtyToDeliver<=0

TODO
* MIs, ErrorMessages etc to prevent fiddling with exported shipment schedules
* dev-test;
* also see & coordinate what's missing

#7012

* Update WEBUI_M_HU_ReturnFromCustomer.java (#7028)

* div. improvements

* Use jackson-stuff in our camel route
* Send feedback to metasfresh
* Update audit records using feedback
* convert JSON to XML
* simplify audit records in metasfresh
* Also
  * CacheInvalidateMultiRequest with better support for RepoIdAwares

  #7012

* fixes

  #7012

* fixes

#7012

* attempt to fix criculary error handling + dependency conversion errors

#7012

* minor

#7012

* minor

#7012

* work on fixing tests

#7012

* attempt to fix dependency conversion errors
#7012

* rename/more classes and modules; meekly start with receipt-candidates

#7012

* attempt to fix dependency conversion errors

#7012

* Add ExportStatus and CanBeExportedFrom for M_ReceiptSchedule

#7012

* Starting with Receipt Candidate API

* move ShipmentScheduleId class
* extract common APIExportAudit and APIExportAuditRepository
* start receipt candidate code (similar to shipment candidate, but e.g. different classes)

#7012

* fix module name

#7012

* Starting with Receipt Candidate API

* pom.xml fix typo in exclusion
* start implementing the camel part as well

#7012

* Upgrade lodash due to security advisory (#7031)

Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>

* Add extra checks for clearing the filter (#7032)

Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>

* solve another depdendency conversion error

#7012

* solve after-refactor-error

#7012

* attempt to solve dependency convergence error

#7012

* work on json-XML-mapping for receipt schedules

#7012

* fix docker image name in build descr

#7012

* bunch of finetuning

#7012

* fix NPE

#7012

* improve logging, do a bit of deduplication

#7012

* minor fix

#7012

* improve route-ids

#7012

* minor tweaks

#7012

* minor tweaks

#7012

* fix problem wrt attribute set instance

#7012

* fix(SEPA Export): schemaLocation (#7034)

* add unit test

#7012

* - use included view from `listHandler` if it exists (#7035)

* do not retry in genereal, but only when uploading the result

#7012

* fix feedback-routes

#7012

* hotfix: filter does not work in "return HUs to customer" view (#7033)

* fix API-Export list value

#7012

* Revert "hotfix: filter does not work in "return HUs to customer" view (#7033)"

This reverts commit 0be2b94

* smaller fixes during review

#7012

* finally managing working tests

#7012

* #7012 Initial commit.

* Revert "#7012 Initial commit."

This reverts commit e2e8a81

* #7012 Initial commit.

* #7012 Second commit

* #7012 Receipt Schedule & Purchase Order adjustments.
   - can no longer reactivate or void purchase order with exported receipt schedules.
   - new process to change the export status of receipt schedules.

* #7012 Deleted ReceiptSchedulePA and moved metods to DAO class.

* #7012
- changed usage of deleted PA class to DAO in C_Order.

* Customer return not working bc HUs cannot be selected (#7040)

#6420
(cherry picked from commit 5be1b54)

* Gh7012 shipmentschedule rest api (#7024)

Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>
Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com>
Co-authored-by: TheBestPessimist <cristian@tbp.land>
Co-authored-by: Kay <kay.kostelnik@metasfresh.com>
Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com>
Co-authored-by: Peter Wyss <peter.wyss@kommunikativ.ch>
Co-authored-by: Kuba Siemiątkowski <kuba@saskla.cz>
Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com>

* add some documentation

* fix build description for de-metas-camel-shipping

* #7012 merged blonde_monkey_uat. Resolved Conflicts.

* #7012 moved migration scripts to right folder. update wrong script number.

Co-authored-by: Tobias Schöneberg <tobias.schoeneberg@metasfresh.com>
Co-authored-by: TheBestPessimist <cristian@tbp.land>
Co-authored-by: Kay <kay.kostelnik@metasfresh.com>
Co-authored-by: Teo Sarca <teo.sarca@metasfresh.com>
Co-authored-by: Petrica Nanca <petrica_nanca@yahoo.com>
Co-authored-by: Petrica Nanca <petrica.nanca@metasfresh.com>
Co-authored-by: Peter Wyss <peter.wyss@kommunikativ.ch>
Co-authored-by: Kuba Siemiątkowski <kuba@saskla.cz>
Co-authored-by: Tobias Schöneberg <metas-ts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrican petrican petrican approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siemiatj @petrican